This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Only build TargetingPack when building on Windows#7709
Merged
stephentoub merged 1 commit intodotnet:masterfrom Oct 19, 2016
Merged
Only build TargetingPack when building on Windows#7709stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
joperezr
approved these changes
Oct 18, 2016
Member
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this
Member
Author
|
@dotnet-bot test Windows_NT x86 legacy_backend Checked build and test |
Member
|
@dotnet-bot test Linux ARM Emulator Cross Release Build please (build was aborted) |
weshaggard
approved these changes
Oct 19, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@joperezr this should solve the issues you were encountering (Tested on Windows & non-Windows, this works as expected).