Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fixing the reference declarations for System.MathF.#7735

Merged
janvorli merged 1 commit intodotnet:masterfrom
tannergooding:math
Oct 20, 2016
Merged

Fixing the reference declarations for System.MathF.#7735
janvorli merged 1 commit intodotnet:masterfrom
tannergooding:math

Conversation

@tannergooding
Copy link
Copy Markdown
Member

@janvorli. The mscorlib reference declarations should have been updated alongside: #7721

It also looks like the reference declarations should have used throw null; instead of return default(float);

Finally, it looks like I should have removed the System.Security.SecuritySafeCritical attribute from System.MathF.Abs since it is no longer an FCALL.

This fixes all three of those issues.

@tannergooding
Copy link
Copy Markdown
Member Author

I went through all the code added in the original PR and ensured that there was no additional fixes required after System.MathF.Abs was modified to call the System.Math.Abs implementation.

@janvorli
Copy link
Copy Markdown
Member

LGTM

@janvorli janvorli merged commit e66fca5 into dotnet:master Oct 20, 2016
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants