This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fixing the reference declarations for System.MathF.#7735
Merged
janvorli merged 1 commit intodotnet:masterfrom Oct 20, 2016
tannergooding:math
Merged
Fixing the reference declarations for System.MathF.#7735janvorli merged 1 commit intodotnet:masterfrom tannergooding:math
janvorli merged 1 commit intodotnet:masterfrom
tannergooding:math
Conversation
Member
Author
|
I went through all the code added in the original PR and ensured that there was no additional fixes required after |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@janvorli. The mscorlib reference declarations should have been updated alongside: #7721
It also looks like the reference declarations should have used
throw null;instead ofreturn default(float);Finally, it looks like I should have removed the
System.Security.SecuritySafeCriticalattribute fromSystem.MathF.Abssince it is no longer an FCALL.This fixes all three of those issues.