This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Jit: spill stack for non-candidate calls#7923
Merged
Merged
Conversation
Closes #7907. Spill the evaluation stack at non-candidate calls since the call may modify locals or args that are currently live on the stack. In the attached test case I can't get the problematic IL sequence to happen for the `F0` variant, but it is there for the `F1` variant. No diffs seen in corlib or any of the framework assemblies that are run via jit-dasm.
Member
Author
|
@pkukol PTAL |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7907.
Spill the evaluation stack at non-candidate calls since the call may
modify locals or args that are currently live on the stack.
In the attached test case I can't get the problematic IL sequence to
happen for the
F0variant, but it is there for theF1variant.No diffs seen in corlib or any of the framework assemblies that are
run via jit-dasm.