Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Streamline LSRA resolution#8207

Merged
CarolEidt merged 1 commit intodotnet:masterfrom
CarolEidt:StreamlineResolution
Dec 15, 2016
Merged

Streamline LSRA resolution#8207
CarolEidt merged 1 commit intodotnet:masterfrom
CarolEidt:StreamlineResolution

Conversation

@CarolEidt
Copy link
Copy Markdown

Only do resolution when required, and only for variables that may need it.

@CarolEidt
Copy link
Copy Markdown
Author

@sivarv @pkukol PTAL.
This reduces the % time spent in LSRA resolution phase when crossgen-ing System.Private.CoreLib from ~1.6% to ~1.2%. There are zero diffs against desktop.
I plan to look into the benefits of not splitting any edges (always resolving on the stack), at least for MinOpts, as a future change.

@sivarv
Copy link
Copy Markdown
Member

sivarv commented Nov 21, 2016

:shipit:

@sivarv
Copy link
Copy Markdown
Member

sivarv commented Nov 21, 2016

Looks Good.
I am assuming that you will be running LSRA stress on x86 and amd64 before merging.

@CarolEidt CarolEidt force-pushed the StreamlineResolution branch from 59c74fe to 6c4e5f7 Compare November 22, 2016 19:22
@CarolEidt
Copy link
Copy Markdown
Author

@dotnet-bot test Windows_NT jitstressregs0x10
@dotnet-bot test Windows_NT jitstressregs0x80
@dotnet-bot test Windows_NT jitstressregs1
@dotnet-bot test Windows_NT jitstressregs2
@dotnet-bot test Windows_NT jitstressregs3
@dotnet-bot test Windows_NT jitstressregs4
@dotnet-bot test Windows_NT jitstressregs8

@CarolEidt CarolEidt force-pushed the StreamlineResolution branch from 913d520 to c553636 Compare November 28, 2016 02:01
@CarolEidt
Copy link
Copy Markdown
Author

@dotnet-bot test Windows_NT jitstressregs0x10
@dotnet-bot test Windows_NT jitstressregs0x80
@dotnet-bot test Windows_NT jitstressregs1
@dotnet-bot test Windows_NT jitstressregs2
@dotnet-bot test Windows_NT jitstressregs3
@dotnet-bot test Windows_NT jitstressregs4
@dotnet-bot test Windows_NT jitstressregs8

@CarolEidt CarolEidt force-pushed the StreamlineResolution branch 2 times, most recently from 973cd98 to 0ccf084 Compare November 30, 2016 22:49
@CarolEidt
Copy link
Copy Markdown
Author

@dotnet-bot test Windows_NT x86 Checked Build and Test

Only do resolution when required, and only for variables that may need it.
@CarolEidt CarolEidt force-pushed the StreamlineResolution branch from 0ccf084 to e94463e Compare December 7, 2016 01:14
@CarolEidt
Copy link
Copy Markdown
Author

@dotnet-bot test Windows_NT jitstressregs0x10
@dotnet-bot test Windows_NT jitstressregs0x80
@dotnet-bot test Windows_NT jitstressregs1
@dotnet-bot test Windows_NT jitstressregs2
@dotnet-bot test Windows_NT jitstressregs3
@dotnet-bot test Windows_NT jitstressregs4
@dotnet-bot test Windows_NT jitstressregs8

@CarolEidt
Copy link
Copy Markdown
Author

@dotnet-bot test Windows_NT x86 Checked jitstressregs0x10
@dotnet-bot test Windows_NT x86 Checked jitstressregs0x80
@dotnet-bot test Windows_NT x86 Checked jitstressregs1
@dotnet-bot test Windows_NT x86 Checked jitstressregs2
@dotnet-bot test Windows_NT x86 Checked jitstressregs3
@dotnet-bot test Windows_NT x86 Checked jitstressregs4
@dotnet-bot test Windows_NT x86 Checked jitstressregs8

@CarolEidt CarolEidt merged commit c8194b0 into dotnet:master Dec 15, 2016
@CarolEidt CarolEidt deleted the StreamlineResolution branch December 15, 2016 17:49
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants