This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] fix and add for x86 cmake configuration#8219
Merged
Conversation
Author
|
You can check with |
Member
|
cc @janvorli |
Author
|
cc @gkhanna79 |
janvorli
reviewed
Nov 21, 2016
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| #include "unixasmmacros.inc" | ||
|
|
Member
There was a problem hiding this comment.
Is it possible to use .intel_syntax noprefix for x86 like we do for AMD64 instead of using the default GAS syntax? It would be highly preferrable.
| elseif(CLR_CMAKE_PLATFORM_ARCH_ARM64) | ||
| add_library_clr(cordbee_wks ${CORDBEE_SOURCES_WKS}) | ||
| elseif(CLR_CMAKE_PLATFORM_ARCH_I386) | ||
| add_library_clr(cordbee_wks ${CORDBEE_SOURCES_WKS} ../${ARCH_SOURCES_DIR}/dbghelpers.S) |
Member
There was a problem hiding this comment.
Would you mind changing the if as follows so that the same body doesn't get repeated three times?
if (CLR_CMAKE_PLATFORM_ARCH_AMD64 OR CLR_CMAKE_PLATFORM_ARCH_ARM OR CLR_CMAKE_PLATFORM_ARCH_I386)
add_library_clr(cordbee_wks ${CORDBEE_SOURCES_WKS} ../${ARCH_SOURCES_DIR}/dbghelpers.S)
elseif()
.
.This patch will add x86 part for cross build - add x86 in build-rootfs and related cross files - add x86 parts in CMakeLists.txt to pass configuration - add required source files to pass configuration
Author
|
@janvorli , no problem, applied. |
sergign60
pushed a commit
to sergign60/coreclr
that referenced
this pull request
Dec 2, 2016
This patch will add x86 part for cross build - add x86 in build-rootfs and related cross files - add x86 parts in CMakeLists.txt to pass configuration - add required source files to pass configuration
99 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
) This patch will add x86 part for cross build - add x86 in build-rootfs and related cross files - add x86 parts in CMakeLists.txt to pass configuration - add required source files to pass configuration Commit migrated from dotnet/coreclr@d4b1a74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch will add x86 part for cross build