[x86/Linux] Fix compilation in pal and context header#8244
Conversation
|
@dotnet-bot test Linux ARM Emulator Cross Debug Build please |
|
@janvorli , @jkotas , @gkhanna79 , PTAL |
| PDWORD Edi; | ||
| PDWORD Ebp; | ||
| PDWORD Esp; | ||
| PDWORD Eip; |
There was a problem hiding this comment.
The last three don't belong here, the rest is correct.
There was a problem hiding this comment.
There is more that do not belong here - there should only be: Ebx, Esi, Edi, Ebp.
There was a problem hiding this comment.
Thanks, use only Ebx, Esi, Edi, Ebp
| #elif defined(__linux__) && defined(_ARM64_) | ||
| #define PAL_CS_NATIVE_DATA_SIZE 116 | ||
| #elif defined(__linux__) && defined(__i386__) | ||
| #define PAL_CS_NATIVE_DATA_SIZE 96 |
|
@seanshpark since you've said it is WIP, I assume there are more changes needed to make PAL compile, right? |
Yes, compile now about 1%, based on the compile. Most changes are under 10% and some are above 90% I think. |
WIP, fix compile error for x86/Linux - add KNONVOLATILE_CONTEXT_POINTERS - add _X86_ codes in pal/context.h
|
I think this title should be more specific. |
gkhanna79
added
the
* NO MERGE *
|
I have marked this PR as no-merge so that you can continue to push changes to it make the PAL compile. Once everything is in order, we can them merge the PR. @seanshpark Let me know if that does not work for you. |
seanshpark
changed the title
|
@gkhanna79 , I think I misused |
gkhanna79
removed
the
* NO MERGE *
[x86/Linux] Fix compilation in pal and context header Commit migrated from dotnet/coreclr@9395bf4
6 participants
Fix compile error for x86/Linux