[x86/linux] Fix redefined DISPATCHER_CONTEXT compile error#8246
Conversation
|
@janvorli , @jkotas , @gkhanna79 , PTAL |
| // | ||
|
|
||
| #if defined(_TARGET_X86_) | ||
| #if defined(_TARGET_X86_) && defined(WIN32) |
There was a problem hiding this comment.
Should this be "defined(_MSC_VER)" to only enable these pragmas when compiling with VC++ toolset and not just win32 (which maybe true for LLVM based compile, for example)?
There was a problem hiding this comment.
This ifdef block doesn't contain just the warning pragma, but also the _DISPATCHER_CONTEXT.
But thinking about it more, I think we should use !defined(FEATURE_PAL) instead, since the other place where the _DISPATCHER_CONTEXT is defined for x86 Linux is included for FEATURE_PAL only.
Btw, it seems the warning disabling pragmas are outdated, there is no function definition between the pragmas.
There was a problem hiding this comment.
Sounds good to me.
it seems the warning disabling pragmas are outdated, there is no function definition between the pragmas.
In this case, @seanshpark can you please remove the pragmas as well?
There was a problem hiding this comment.
OK, I'll change to !defined(FEATURE_PAL) and remove pragmas
|
|
WIP, fix compile error for x86/Linux - add directive WIN32 to current DISPATCHER_CONTEXT in clrnt.h - add DISPATCHER_CONTEXT for x86 in palrt.h
|
@dotnet-bot test Windows_NT x64 Debug Build and Test please |
|
done changing to !defined(FEATURE_PAL) |
WIP, fix compile error for x86/Linux - add directive WIN32 to current DISPATCHER_CONTEXT in clrnt.h - add DISPATCHER_CONTEXT for x86 in palrt.h
…reclr#8246) WIP, fix compile error for x86/Linux - add directive WIN32 to current DISPATCHER_CONTEXT in clrnt.h - add DISPATCHER_CONTEXT for x86 in palrt.h Commit migrated from dotnet/coreclr@2c67c72
5 participants
WIP, fix compile error for x86/Linux