This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Fix compile error redifinition RUNTIME_FUNCTION#8249
Merged
Conversation
Author
|
@janvorli , @jkotas , @gkhanna79 , PTAL |
janvorli
reviewed
Nov 22, 2016
| PTR_CORCOMPILE_IMPORT_SECTION; | ||
|
|
||
| #ifdef _TARGET_X86_ | ||
| #if defined(_TARGET_X86_) && defined(WIN32) |
Member
There was a problem hiding this comment.
Actually, we should use !defined(FEATURE_PAL) instead of defined(WIN32) everywhere. I have scanned our sources and we don't use WIN32 anywhere except for the PAL tests, which has historical reasons.
Add !FEATURE_PAL directive for x86 as RUNTIME_FUNCTION is defined in pal
Author
|
Changed to use |
99 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…oreclr#8249) Add !FEATURE_PAL directive for x86 as RUNTIME_FUNCTION is defined in pal Commit migrated from dotnet/coreclr@20f48eb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add !FEATURE_PAL directive for x86 as RUNTIME_FUNCTION is defined in pal