This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Fix unknown type name 'EHWatsonBucketTracker'#8250
Closed
seanshpark wants to merge 1 commit into
Closed
[x86/Linux] Fix unknown type name 'EHWatsonBucketTracker'#8250seanshpark wants to merge 1 commit into
seanshpark wants to merge 1 commit into
Conversation
WIP, fix compile error for x86/Linux - wrap with !FEATURE_PAL
Member
|
@seanshpark I don't think we will use the windows x86 exception handling code for handling exceptions on x86 Linux. We should rather use the stuff we use for AMD64, ARM32 and ARM64. So I believe this change and the change in #8251 should not be needed. But you'll need to ensure WIN64EXCEPTIONS is defined for x86 Unix. There are three places where it is set: src/inc/corcompile.h, src/inc/switches.h and src/zap/common.h. |
Author
|
@janvorli , Thank you. I'll close this and 8251 and try to enable WIN64EXCEPTIONS for x86/Linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP, fix compile error for x86/Linux