Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[x86/Linux] Fix no matching function for call to 'InternalCreateThread'#8265

Merged
janvorli merged 1 commit into
dotnet:masterfrom
seanshpark:x86pal09
Nov 23, 2016
Merged

[x86/Linux] Fix no matching function for call to 'InternalCreateThread'#8265
janvorli merged 1 commit into
dotnet:masterfrom
seanshpark:x86pal09

Conversation

@seanshpark
Copy link
Copy Markdown

@seanshpark seanshpark commented Nov 23, 2016

Fix compile error for x86/Linux

  • fix calling convention by adding PALAPI to TerminationRequestHandlingRoutine

InternalCreateThread is using TerminationRequestHandlingRoutine like

                    palErr = InternalCreateThread(pthrWorker,
                                      NULL,
                                      0,
                                      &TerminationRequestHandlingRoutine,
                                      NULL,

[x86/Linux] Fix no matching function for call to 'InternalCreateThread'
f758727 
Fix compile error for x86/Linux
- fix calling convention by adding PALAPI to TerminationRequestHandlingRoutine
@seanshpark
Copy link
Copy Markdown
Author

seanshpark commented Nov 23, 2016

@dotnet-bot test Ubuntu x64 Checked Build and Test please

@seanshpark
Copy link
Copy Markdown
Author

seanshpark commented Nov 23, 2016

@janvorli , @jkotas , @gkhanna79 , PTAL

janvorli
janvorli approved these changes Nov 23, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit c581947 into dotnet:master Nov 23, 2016
@seanshpark seanshpark deleted the x86pal09 branch November 23, 2016 22:39
sergign60 pushed a commit to sergign60/coreclr that referenced this pull request Dec 2, 2016
@seanshpark @sergign60
[x86/Linux] Fix no matching function for call to 'InternalCreateThrea…
5dfd360 
…d' (dotnet#8265)

Fix compile error for x86/Linux
- fix calling convention by adding PALAPI to TerminationRequestHandlingRoutine
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
@seanshpark seanshpark mentioned this pull request Jan 31, 2020
Closed
99 tasks
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@seanshpark @janvorli
[x86/Linux] Fix no matching function for call to 'InternalCreateThrea…
125e33c 
…d' (dotnet/coreclr#8265)

Fix compile error for x86/Linux
- fix calling convention by adding PALAPI to TerminationRequestHandlingRoutine

Commit migrated from dotnet/coreclr@c581947
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@janvorli janvorli janvorli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@seanshpark @janvorli @karelz @dnfclas