This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Fix compile error in zapcode#8294
Merged
Merged
Conversation
|
Please ignore the x86 compatjit and x86 legacy_backend failures. The jobs have been removed from future PRs. |
jkotas
reviewed
Nov 24, 2016
| } | ||
|
|
||
| #elif defined(_TARGET_ARM_) || defined(_TARGET_ARM64_) | ||
| #elif defined(_TARGET_ARM_) || defined(_TARGET_ARM64_) || (defined(_TARGET_X86_) && defined(FEATURE_PAL)) |
Member
There was a problem hiding this comment.
This ifdef stay as is - we should not have this kind of unwind info for x86.
This is part of the x86 managed code ABI (described in https://github.com/dotnet/coreclr/blob/master/Documentation/botr/clr-abi.md). The x86 managed code ABI should stay same between Windows and Unix. Otherwise, the x86 Linux port will turn into a very long and complex project.
Author
There was a problem hiding this comment.
OK, I'll read the document and see how to fix the compile error.
Fix compile error for x86/Linux - Remove ZapUnwindInfo WIN64EXCEPTIONS codes for x86/Linux - fix "use of undeclared identifier 'NEED_TO_PORT_THIS_ONE'" - fix "unknown type name 'UNWIND_INFO'" - fix "use of undeclared identifier 'READYTORUN_HELPER_PersonalityRoutineFilterFunclet'"
Author
Member
|
LGTM. Thanks! |
99 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix compile error for x86/Linux - Remove ZapUnwindInfo WIN64EXCEPTIONS codes for x86/Linux - fix "use of undeclared identifier 'NEED_TO_PORT_THIS_ONE'" - fix "unknown type name 'UNWIND_INFO'" - fix "use of undeclared identifier 'READYTORUN_HELPER_PersonalityRoutineFilterFunclet'" Commit migrated from dotnet/coreclr@2acb29c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix compile error for x86/Linux