This repository was archived by the owner on Jan 23, 2023. It is now read-only.
StringBuilder.AppendJoin (appending lists to StringBuilder) #8303
Closed
AlexRadch wants to merge 4 commits into
Closed
StringBuilder.AppendJoin (appending lists to StringBuilder) #8303AlexRadch wants to merge 4 commits into
AlexRadch wants to merge 4 commits into
Conversation
svick
reviewed
Nov 29, 2016
| using System.Threading; | ||
| using System.Globalization; | ||
| using System.Diagnostics.Contracts; | ||
| using Collections.Generic; |
Member
There was a problem hiding this comment.
Why does this using not follow the same convention as the previous ones, i.e. to include System even when it's not necessary?
Author
There was a problem hiding this comment.
Sorry I do not fully understand. It should be changed to
using Collections;
using Collections.Generic;Or what?
Member
There was a problem hiding this comment.
No, I meant changing it to:
using System.Collections.Generic;All the old usings do that.
Author
|
I recreated repository fork so I created new PR #8350 with the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement StringBuilder.AppendJoin API. See https://github.com/dotnet/corefx/issues/3419