Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Enable field EndAddress only for AMD64 in PAL of RUNTIME_FUNCTION#8305

Merged
janvorli merged 1 commit into
dotnet:masterfrom
seanshpark:chk
Nov 25, 2016
Merged

Enable field EndAddress only for AMD64 in PAL of RUNTIME_FUNCTION#8305
janvorli merged 1 commit into
dotnet:masterfrom
seanshpark:chk

Conversation

@seanshpark
Copy link
Copy Markdown

@seanshpark seanshpark commented Nov 25, 2016

Enable field EndAddress only for AMD64 in PAL

As noted in #8272 (comment)

Comment thread src/pal/inc/pal.h
typedef struct _RUNTIME_FUNCTION {
DWORD BeginAddress;
DWORD EndAddress;
#ifdef _AMD64_
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the EndAddress was the one. Based on the definition for windows in corcompile.h.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops...

@seanshpark
Copy link
Copy Markdown
Author

@dotnet-bot test Windows_NT x64 Release Priority 1 Build and Test please

@seanshpark seanshpark changed the title Check build third field in RUNTIME_FUNCTION Enable field EndAddress only for AMD64 in PAL of RUNTIME_FUNCTION Nov 25, 2016
Copy link
Copy Markdown
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janvorli janvorli merged commit c958ed1 into dotnet:master Nov 25, 2016
@seanshpark seanshpark deleted the chk branch November 28, 2016 23:22
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants