This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Add virtual dtor for ArrayStubCache class#8339
Merged
Conversation
parjong
changed the title
Author
|
@dotnet-bot test Linux ARM Emulator Cross Debug Build please |
janvorli
suggested changes
Nov 29, 2016
| StubLinker *psl); | ||
| virtual UINT Length(const BYTE *pRawStub); | ||
|
|
||
| virtual ~ArrayStubCache() = default; |
Member
There was a problem hiding this comment.
This is not needed since you've made the destructor of the base class virtual.
janvorli
approved these changes
Nov 29, 2016
Author
|
@dotnet-bot test Linux ARM Emulator Cross Debug Build please |
99 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…#8339) * Adds virtual dtor for ArrayStubCache class * Remove unnecessary default destructor Commit migrated from dotnet/coreclr@89440da
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds virtual destructor for ArrayStubCache class (and its super classes) to fix the following warning during x86/Linux build: