Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[x86/Linux] Fix mismatch over LPOVERLAPPED_COMPLETION_ROUTINE#8364

Merged
janvorli merged 2 commits into
dotnet:masterfrom
parjong:fix/LPOVERLAPPED_COMPLETION_ROUTINE_mismatch
Nov 30, 2016
Merged

[x86/Linux] Fix mismatch over LPOVERLAPPED_COMPLETION_ROUTINE#8364
janvorli merged 2 commits into
dotnet:masterfrom
parjong:fix/LPOVERLAPPED_COMPLETION_ROUTINE_mismatch

Conversation

@parjong
Copy link
Copy Markdown

@parjong parjong commented Nov 29, 2016

Those functions are compared with Function variable of
LPOVERLAPPED_COMPLETION_ROUTINE type, but has inconsistent type,

  • WaitIOCompletionCallback,
  • CallbackForInitiateDrainageOfCompletionPortQueue
  • CallbackForContinueDrainageOfCompletionPortQueue
    This inconsistency results in compile error for x86/Linux build.

This commit fixes such inconsistency.

Those functions are compared with Function variable of
LPOVERLAPPED_COMPLETION_ROUTINE type, but has inconsistent type,
 - WaitIOCompletionCallback,
 - CallbackForInitiateDrainageOfCompletionPortQueue
 - CallbackForContinueDrainageOfCompletionPortQueue
This inconsistency results in compile error for x86/Linux build.

This commit fixes such inconsistency.
@parjong parjong changed the title Fix the mismatch over LPOVERLAPPED_COMPLETION_ROUTINE [x86/Linux] Fix the mismatch over LPOVERLAPPED_COMPLETION_ROUTINE Nov 29, 2016
@parjong
Copy link
Copy Markdown
Author

parjong commented Nov 29, 2016

\CC @seanshpark

@parjong parjong changed the title [x86/Linux] Fix the mismatch over LPOVERLAPPED_COMPLETION_ROUTINE [x86/Linux] Fix mismatch over LPOVERLAPPED_COMPLETION_ROUTINE Nov 29, 2016
Copy link
Copy Markdown
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@janvorli janvorli merged commit 0dca898 into dotnet:master Nov 30, 2016
@parjong parjong deleted the fix/LPOVERLAPPED_COMPLETION_ROUTINE_mismatch branch November 30, 2016 23:15
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…/coreclr#8364)

* Fix the mismatch over LPOVERLAPPED_COMPLETION_ROUTINE

Those functions are compared with Function variable of
LPOVERLAPPED_COMPLETION_ROUTINE type, but has inconsistent type,
 - WaitIOCompletionCallback,
 - CallbackForInitiateDrainageOfCompletionPortQueue
 - CallbackForContinueDrainageOfCompletionPortQueue
This inconsistency results in compile error for x86/Linux build.

This commit fixes such inconsistency.

* Revises 'CallbackForContinueDrainageOfCompletionPortQueue'


Commit migrated from dotnet/coreclr@0dca898
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants