Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[x86/Linux] Declare CtorFtnType only when it is used#8378

Merged
janvorli merged 1 commit intodotnet:masterfrom
parjong:fix/unused_typedef_arraynative
Nov 30, 2016
Merged

[x86/Linux] Declare CtorFtnType only when it is used#8378
janvorli merged 1 commit intodotnet:masterfrom
parjong:fix/unused_typedef_arraynative

Conversation

@parjong
Copy link
Copy Markdown

@parjong parjong commented Nov 30, 2016

In x86, CtorFtnType is used only for release build, but is declared even for debug build (which results in unused-local-typedef error).

@parjong parjong changed the title Declare CtorFtnType only when it is used [x86/Linux] Declare CtorFtnType only when it is used Nov 30, 2016
@parjong
Copy link
Copy Markdown
Author

parjong commented Nov 30, 2016

\CC @seanshpark

@parjong
Copy link
Copy Markdown
Author

parjong commented Nov 30, 2016

@dotnet-bot test Ubuntu x64 Checked Build and Test please

Copy link
Copy Markdown
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@janvorli janvorli merged commit 5a8a0c8 into dotnet:master Nov 30, 2016
@parjong parjong deleted the fix/unused_typedef_arraynative branch November 30, 2016 23:17
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants