[x86/Linux] Revises exception handling macros for x86/Linux#8381
[x86/Linux] Revises exception handling macros for x86/Linux#8381parjong wants to merge 1 commit into
Conversation
|
\CC @seanshpark |
|
@parjong seeing the several recent changes in the exception handling related stuff, I am worried that after deciding to not to try to define the WIN64EXCEPTIONS, we are heading into the same mess we were trying to avoid, this time with trying to ifdef out chunks of x86 style exception handling code. |
I agree. It is hard to tell whether the changes like this one are going in the right direction without seeing the more complete picture. |
|
I would recommend to focus on without WIN64EXCEPTIONS for the time being. It will get you to a working hello world much faster. Note that we had a working MacOS x86 port before for Silverlight browser plugin. It was on without WIN64EXCEPTIONS plan. If you stay on the without WIN64EXCEPTIONS you are basically just fixing bit rot and catching up with changes that happened since then. This territory was fully explored before. The with WIN64EXCEPTIONS plan is unexplored territory for x86. |
|
@jkotas I'll focus on that approach. Thank you. |
|
The recent changes require the revision of this PR. I'll re-open this PR or submit a new PR when it is ready. |
This commit revises exception handling macros similarly as amd64/Linux.