Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[x86/Linux] Fix cannot jump from this goto statement to its label#8389

Closed
seanshpark wants to merge 1 commit into
dotnet:masterfrom
seanshpark:x86jit05
Closed

[x86/Linux] Fix cannot jump from this goto statement to its label#8389
seanshpark wants to merge 1 commit into
dotnet:masterfrom
seanshpark:x86jit05

Conversation

@seanshpark
Copy link
Copy Markdown

Fix compile error for x86/Linux

  • move variable declaration before jump
  • fix "cannot jump from this goto statement to its label"

Fix compile error for x86/Linux
- move variable declaration before jump
- fix "cannot jump from this goto statement to its label"
@seanshpark
Copy link
Copy Markdown
Author

cc @parjong

@seanshpark
Copy link
Copy Markdown
Author

@janvorli , formatting error logs shows this but I don't know how to fix this. Can you please help?

clang-format: there are formatting errors in /mnt/j/workspace/dotnet_coreclr/master/x64_ubuntu_formatting_prtest/src/jit/codegenlegacy.cpp
05:26:42 At Line 459 Before:
05:26:42     bool setFlags = (tree != NULL) && tree->gtSetFlags();
05:26:42 After:
05:26:42     bool     setFlags = (tree != NULL) && tree->gtSetFlags();
05:26:42 At Line 460 Before:
05:26:42     insFlags flags = INS_FLAGS_DONT_CARE;
05:26:42 After:
05:26:42     insFlags flags    = INS_FLAGS_DONT_CARE;
05:26:42 At Line 6955 Before:
05:26:42     regMaskTP addrReg = genMakeRvalueAddressable(op2, RBM_ALLINT, RegSet::KEEP_REG, isSmallConst);
05:26:42 After:
05:26:42     regMaskTP addrReg     = genMakeRvalueAddressable(op2, RBM_ALLINT, RegSet::KEEP_REG, isSmallConst);
05:26:42 At Line 6956 Before:
05:26:42     bool op2Released = false;
05:26:42 After:
05:26:42     bool      op2Released = false;
05:26:42 At Line 6957 Before:
05:26:42     emitAttr opSize = EA_UNKNOWN;
05:26:42 After:
05:26:42     emitAttr  opSize = EA_UNKNOWN;
05:26:42 At Line 6957 Before:
05:26:42     emitAttr  opSize = EA_UNKNOWN;
05:26:42 After:
05:26:42     emitAttr  opSize      = EA_UNKNOWN;
05:26:42 
05:26:42 Clang-format found formatting errors.

@seanshpark
Copy link
Copy Markdown
Author

@dotnet-bot test Ubuntu x64 Formatting please

@janvorli
Copy link
Copy Markdown
Member

@dotnet/jit-contrib can one of you help figure out the formatting problem here? I am not familiar with the output of the formatting error and it looks quite strange.

@michellemcdaniel
Copy link
Copy Markdown

@janvorli
Copy link
Copy Markdown
Member

@adiaaida thank you for the advice. @seanshpark can you please do that?

@seanshpark
Copy link
Copy Markdown
Author

Problem of this PR has been fixed with #8337.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants