Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[x86/Linux] Fix mismatch between signature and implementation of ActivationFunctions#8394

Merged
janvorli merged 1 commit into
dotnet:masterfrom
parjong:fix/mismatch_ActivationFunction
Nov 30, 2016
Merged

[x86/Linux] Fix mismatch between signature and implementation of ActivationFunctions#8394
janvorli merged 1 commit into
dotnet:masterfrom
parjong:fix/mismatch_ActivationFunction

Conversation

@parjong
Copy link
Copy Markdown

@parjong parjong commented Nov 30, 2016

PAL_ActivationFunction and PAL_SafeActivationCheckFunction types are defined without PALAPI attribute, but HandleGCSuspensionForInterruptedThread and CheckActivationSafePoint functions are implemented with PALAPI attribute.

@parjong parjong changed the title Fix mismatch between signature and implementation of ActivationFunctions [x86/Linux] Fix mismatch between signature and implementation of ActivationFunctions Nov 30, 2016
@parjong
Copy link
Copy Markdown
Author

parjong commented Nov 30, 2016

\CC @seanshpark

Copy link
Copy Markdown
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit 1ab34fa into dotnet:master Nov 30, 2016
@parjong parjong deleted the fix/mismatch_ActivationFunction branch November 30, 2016 23:18
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants