This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Change NYI to be a noway_assert if ALT_JIT is not defined#8395
Merged
Conversation
We recently changed RyuJIT/x86 to be the default JIT. However, there are still a few NYI that can happen, such as when enabling SIMD, which is not enabled yet. However, there is no "fallback" JIT anymore. So just treat all NYI as asserts.
Author
|
@dotnet/jit-contrib PTAL |
Author
|
@mmitche @swgillespie my "x64 Release Priority 1 Build and Test" failed with: Is this a known failure? Is it common? Is it being fixed? https://ci.dot.net/job/dotnet_coreclr/job/master/job/x64_release_windows_nt_pri1_prtest/549/ |
Author
|
@dotnet-bot test Windows_NT x64 Release Priority 1 Build and Test |
|
@BruceForstall It's known, yes: https://github.com/dotnet/coreclr/issues/7762 |
|
LGTM |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Change NYI to be a noway_assert if ALT_JIT is not defined Commit migrated from dotnet/coreclr@0b0d51e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently changed RyuJIT/x86 to be the default JIT. However, there
are still a few NYI that can happen, such as when enabling SIMD,
which is not enabled yet. However, there is no "fallback" JIT anymore.
So just treat all NYI as asserts.