Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Change NYI to be a noway_assert if ALT_JIT is not defined#8395

Merged
BruceForstall merged 1 commit into
dotnet:masterfrom
BruceForstall:FixNYI
Nov 30, 2016
Merged

Change NYI to be a noway_assert if ALT_JIT is not defined#8395
BruceForstall merged 1 commit into
dotnet:masterfrom
BruceForstall:FixNYI

Conversation

@BruceForstall
Copy link
Copy Markdown

We recently changed RyuJIT/x86 to be the default JIT. However, there
are still a few NYI that can happen, such as when enabling SIMD,
which is not enabled yet. However, there is no "fallback" JIT anymore.
So just treat all NYI as asserts.

We recently changed RyuJIT/x86 to be the default JIT. However, there
are still a few NYI that can happen, such as when enabling SIMD,
which is not enabled yet. However, there is no "fallback" JIT anymore.
So just treat all NYI as asserts.
@BruceForstall
Copy link
Copy Markdown
Author

@dotnet/jit-contrib PTAL

@BruceForstall
Copy link
Copy Markdown
Author

@mmitche @swgillespie my "x64 Release Priority 1 Build and Test" failed with:

C:\Program Files (x86)\MSBuild\14.0\bin\Microsoft.Common.CurrentVersion.targets(4412,5): error MSB3491: Could not write lines to file "D:\j\workspace\x64_release_w---0575cb46\bin\int\Managed\GC\Stress\Tests\DirectedGraph\DirectedGraph.csproj.FileListAbsolute.txt". The process cannot access the file 'D:\j\workspace\x64_release_w---0575cb46\bin\int\Managed\GC\Stress\Tests\DirectedGraph\DirectedGraph.csproj.FileListAbsolute.txt' because it is being used by another process. [D:\j\workspace\x64_release_w---0575cb46\tests\src\GC\Stress\Tests\DirectedGraph.csproj]
07:39:33 Command execution failed with exit code 1.
07:39:33 BUILDTEST: Error: build failed. Refer to the build log files for details:

Is this a known failure? Is it common? Is it being fixed?

https://ci.dot.net/job/dotnet_coreclr/job/master/job/x64_release_windows_nt_pri1_prtest/549/

@BruceForstall
Copy link
Copy Markdown
Author

@dotnet-bot test Windows_NT x64 Release Priority 1 Build and Test

@swgillespie
Copy link
Copy Markdown

@pgavlin
Copy link
Copy Markdown

pgavlin commented Nov 30, 2016

LGTM

@BruceForstall BruceForstall merged commit 0b0d51e into dotnet:master Nov 30, 2016
@BruceForstall BruceForstall deleted the FixNYI branch November 30, 2016 21:31
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Change NYI to be a noway_assert if ALT_JIT is not defined

Commit migrated from dotnet/coreclr@0b0d51e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants