This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Widen basic block flag field to 64 bits#8674
Merged
Merged
Conversation
Member
Author
|
cc @dotnet/jit-contrib No diffs on x64 windows CoreCLR+FX |
Flag field is currently full, and I need at least one more bit to identify the start of a cloned finally. Widen to 64 bits and update a few uses. Also removed an unused copy.
AndyAyersMS
force-pushed
the
BiggerBlockFlag
branch
from
787eea7 to
79bacd6
Compare
Member
Author
|
Pushed an update for formatting/gotos. |
|
Perhaps we should have a |
JosephTremoulet
approved these changes
Dec 19, 2016
JosephTremoulet
left a comment
JosephTremoulet
left a comment
There was a problem hiding this comment.
Agree with both @mikedn's points. LGTM.
Member
Author
|
I find typedefs of basic types to be more confusing than helpful -- I suppose it makes search and replace easier, but you usually end up having to know what the real type is anyways when you do anything other than make copies. So will leave this as is... |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Widen basic block flag field to 64 bits Commit migrated from dotnet/coreclr@8395eb5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flag field is currently full, and I need at least one more bit to identify
the start of a cloned finally.
Widen to 64 bits and update a few uses. Also removed an unused copy.