This repository was archived by the owner on Jan 23, 2023. It is now read-only.
TimeZoneInfo Cleanup#8720
Merged
Merged
Conversation
Update TimeZoneInfo to use CoreFX coding style and other minor cleanup.
justinvp
force-pushed
the
tzi_cleanup
branch
from
d1d2e60 to
eb23cd8
Compare
Member
|
Thank you for doing this - it is work towards step 1 in https://github.com/dotnet/coreclr/issues/972. |
Merged
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Update TimeZoneInfo to use CoreFX coding style and other minor cleanup. Commit migrated from dotnet/coreclr@9450264
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update TimeZoneInfo to use the CoreFX coding style and other minor cleanup.
In a follow-up PR, I'm thinking about separating out the Win32 and Unix implementations into separate files like in CoreRT. Then I'll submit a PR in the CoreRT repo to reconcile all the changes between the two repos, getting them as close as possible.