Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Use armel instead of arm-softfp#8771

Merged
janvorli merged 2 commits into
dotnet:masterfrom
hqueue:arm/rootfs/armel
Jan 5, 2017
Merged

Use armel instead of arm-softfp#8771
janvorli merged 2 commits into
dotnet:masterfrom
hqueue:arm/rootfs/armel

Conversation

@hqueue
Copy link
Copy Markdown
Member

@hqueue hqueue commented Jan 2, 2017 •
edited
Loading

Related issue: #8770

Rename directory cross/arm-softfp to cross/armel.
Update build scripts, configuration files and CI scripts for arm-softfp
Also fix bug in rootfs of arm-softfp

@hqueue hqueue changed the title Use armel instead of arm-softfp for rootfs [WIP] Use armel instead of arm-softfp for rootfs Jan 2, 2017
@hseok-oh
Copy link
Copy Markdown

hseok-oh commented Jan 2, 2017 •
edited
Loading

It does not work by only this PR. (will fail ARM build in all PRs)
You need to merge PR #8747, and https://github.com/hseok-oh/coreclr/tree/softfp_to_armel
If you commit additional fix, I will close PR #8747.

@hseok-oh hseok-oh mentioned this pull request Jan 2, 2017
Closed
@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Jan 2, 2017

@hseok-oh I've just merged your commits into this PR and let's see CI works well. Thanks!

@hqueue hqueue changed the title [WIP] Use armel instead of arm-softfp for rootfs [WIP] Use armel instead of arm-softfp Jan 2, 2017
@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Jan 2, 2017

@dotnet-bot test Linux ARM Emulator Cross Release Build
@dotnet-bot test Linux ARM Emulator Cross Debug Build

@chunseoklee chunseoklee mentioned this pull request Jan 3, 2017
Merged
@jyoungyun
Copy link
Copy Markdown

jyoungyun commented Jan 3, 2017

LGTM

@hqueue hqueue mentioned this pull request Jan 3, 2017
Merged
@hqueue hqueue changed the title [WIP] Use armel instead of arm-softfp Use armel instead of arm-softfp Jan 3, 2017
@hqueue
Use armel instead of arm-softfp for CoreCLR
4e90b45 
- Update scripts for rootfs, build, build system generation and CI
- Update managed build project
- Rename rootfs directory
- Fix bug in rootfs script related to lldb package
  lldb package only usable lldb-3.5-dev for jessie/arm-softfp
  We cannot get lldb-3.6-dev or lldb-3.8-dev from jessie/arm-softfp repository

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Singed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Jan 4, 2017 •
edited
Loading

@gkhanna79 PTAL. This replaces arm-softfp with armel in build/rootfs/CI scripts and etc. and we succesfully built CoreCLR for armel at loca host PC.

@mellinoe I saw you merged a PR(dotnet/corefx#14803) in CoreFX. Can you please also take a look at this?

janvorli
janvorli reviewed Jan 4, 2017
View reviewed changes
Comment thread tests/scripts/arm32_ci_script.sh Outdated
#Apply the changes needed to build for the emulator rootfs
(set +x; echo 'Applying cross build patch to suit Linux ARM emulator rootfs')
git am < "$__ARMEmulRootfs"/dotnet/setenv/coreclr_cross.patch
#(set +x; echo 'Applying cross build patch to suit Linux ARM emulator rootfs')
Copy link
Copy Markdown
Member

@janvorli janvorli Jan 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is no longer needed, could you please delete all the commented out lines instead?

Copy link
Copy Markdown
Member Author

@hqueue hqueue Jan 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will update it.

@gkhanna79
Copy link
Copy Markdown
Member

gkhanna79 commented Jan 4, 2017

LGTM modulo comments from @janvorli. We can merge this once that is addressed.

@hqueue
Update ARM32 CI script
c72f6cb 
We don't need a patch anymore, because we fixed cmake file.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Jan 5, 2017

@dotnet-bot test Linux ARM Emulator Cross Debug Build

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Jan 5, 2017

@janvorli @gkhanna79 I've update PR with feedback and all CI tests are passed. PTAL.

janvorli
janvorli approved these changes Jan 5, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit 165fa5c into dotnet:master Jan 5, 2017
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
@hqueue hqueue mentioned this pull request Jan 30, 2020
Closed
42 tasks
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@hqueue @janvorli
Use armel instead of arm-softfp (dotnet/coreclr#8771)
df0d7d9 
* Use armel instead of arm-softfp for CoreCLR

- Update scripts for rootfs, build, build system generation and CI
- Update managed build project
- Rename rootfs directory
- Fix bug in rootfs script related to lldb package
  lldb package only usable lldb-3.5-dev for jessie/arm-softfp
  We cannot get lldb-3.6-dev or lldb-3.8-dev from jessie/arm-softfp repository

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Singed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>

* Update ARM32 CI script

We don't need a patch anymore, because we fixed cmake file.

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>


Commit migrated from dotnet/coreclr@165fa5c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@janvorli janvorli janvorli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@hqueue @hseok-oh @jyoungyun @gkhanna79 @janvorli @karelz @dnfclas