This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Generate nuget package for armel (Tizen, Debian)#8827
Merged
Conversation
- Tizen 4.0.0 - Debian 8
Author
|
@gkhanna79 PTAL |
gkhanna79
reviewed
Jan 19, 2017
| <OSGroup>Linux</OSGroup> | ||
| <Platform>amd64</Platform> | ||
| </Project> | ||
| <Project Condition="'$(TargetsLinux)' == 'true' and '$(DistroRid)' == 'tizen.4.0.0-armel'" Include="tizen/4.0.0/Microsoft.NETCore.ILAsm.pkgproj"> |
Member
There was a problem hiding this comment.
@hseok-oh Can you remind me again if Tizen is Ubuntu armel or Debian armel? If the latter, then do we need this for Tizen at all?
gkhanna79
reviewed
Jan 19, 2017
| <ItemGroup> | ||
| <NativeSplittableBinary Include="$(BinDir)libcoreclr.so" /> | ||
| <NativeSplittableBinary Include="$(BinDir)libcoreclrtraceptprovider.so" /> | ||
| <NativeSplittableBinary Condition="'$(PackagePlatform)' != 'armel'" Include="$(BinDir)libcoreclrtraceptprovider.so" /> |
Member
There was a problem hiding this comment.
Does this not build for armel but builds for arm?
Author
There was a problem hiding this comment.
@gkhanna79 armel has same problem as arm. #8684.
And I heard tizen cannot use llting because of security problem @chunseoklee
gkhanna79
reviewed
Jan 19, 2017
| <ArchitectureSpecificNativeFile Include="$(BinDir)sosdocsunix.txt" /> | ||
| <ArchitectureSpecificNativeFile Include="$(BinDir)mscorlib.ni.dll" /> | ||
| <ArchitectureSpecificNativeFile Include="$(BinDir)System.Private.CoreLib.ni.dll" /> | ||
| <ArchitectureSpecificNativeFile Condition="'$(PackagePlatform)' != 'armel'" Include="$(BinDir)mscorlib.ni.dll" /> |
Member
There was a problem hiding this comment.
Why do we have this? Shouldnt crossgen be working to generate this?
Author
There was a problem hiding this comment.
@gkhanna79 Yes. Crossgen (in build host) does not work yet.
Author
|
@gkhanna79 Is there anything to do more? |
gkhanna79
approved these changes
Feb 6, 2017
42 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Generate nuget package for armel (Tizen, Debian) Commit migrated from dotnet/coreclr@a60c064
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue: dotnet/core-setup#725