Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[x86/Linux] Port 'FaultingExceptionFrame::UpdateRegDisplay'#8993

Merged
janvorli merged 1 commit into
dotnet:masterfrom
parjong:fix/x86_FaultingExceptionFrame_UpdateRegDisplay
Jan 19, 2017
Merged

[x86/Linux] Port 'FaultingExceptionFrame::UpdateRegDisplay'#8993
janvorli merged 1 commit into
dotnet:masterfrom
parjong:fix/x86_FaultingExceptionFrame_UpdateRegDisplay

Conversation

@parjong
Copy link
Copy Markdown

@parjong parjong commented Jan 18, 2017

This was a part of #8981, but seems to be necessary to enable x86/Linux exception handling.

@parjong
Copy link
Copy Markdown
Author

parjong commented Jan 18, 2017

\CC @seanshpark

@parjong
Copy link
Copy Markdown
Author

parjong commented Jan 19, 2017 •
edited
Loading

@janvorli The following tests failed with this PR (You could see full log here)

  • GC.Regressions_v2_0_beta1_149926_149926_149926._Regressions_v2_0_beta1_149926_149926_149926_cmd
  • JIT.Regression_CLR_x86_JIT_V1_M12_Beta2_b91377_b91377_b91377.Regression_CLR_x86_JIT_V1_M12 - Beta2_b91377_b91377_b91377_cmd
  • JIT.jit64_opt_cse_HugeField2_HugeField2._jit64_opt_cse_HugeField2_HugeField2_cmd

Is it possible that this PR affects x64/Windows port?, or are there any known issues related with these tests?

@parjong
Copy link
Copy Markdown
Author

parjong commented Jan 19, 2017

@dotnet-bot test Windows_NT x64 Debug Build and Test please

@janvorli
Copy link
Copy Markdown
Member

janvorli commented Jan 19, 2017

@parjong no, the change code is purely x86 code and it is not used on other architectures. But I have checked the recent test jobs and I can see that few semi-random tests in the Windows NT run fail intermittently, so it is probably the case here.

@parjong
Copy link
Copy Markdown
Author

parjong commented Jan 19, 2017

@janvorli Thank you for confirm!

@parjong
Copy link
Copy Markdown
Author

parjong commented Jan 19, 2017

@dotnet-bot test Windows_NT x64 Debug Build and Test please

@parjong parjong mentioned this pull request Jan 19, 2017
Closed
janvorli
janvorli approved these changes Jan 19, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit 0d04afc into dotnet:master Jan 19, 2017
sergign60 pushed a commit to sergign60/coreclr that referenced this pull request Jan 19, 2017
@parjong @sergign60
[x86/Linux] Port 'FaultingExceptionFrame::UpdateRegDisplay' (dotnet#8993
0a37e65 
)
@parjong parjong deleted the fix/x86_FaultingExceptionFrame_UpdateRegDisplay branch January 20, 2017 00:17
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@parjong @janvorli
[x86/Linux] Port 'FaultingExceptionFrame::UpdateRegDisplay' (dotnet/c…
d8778d7 
…oreclr#8993)

Commit migrated from dotnet/coreclr@0d04afc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@janvorli janvorli janvorli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@parjong @janvorli @karelz @dnfclas