Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Remove PALAPI attribute from callback types#9075

Merged
jkotas merged 1 commit into
dotnet:masterfrom
parjong:fix/remove_PALAPI
Jan 24, 2017
Merged

Remove PALAPI attribute from callback types#9075
jkotas merged 1 commit into
dotnet:masterfrom
parjong:fix/remove_PALAPI

Conversation

@parjong
Copy link
Copy Markdown

@parjong parjong commented Jan 24, 2017

#8629 removes PALAPI attributes from PTERMINATION_REQUEST_HANDLER and PGET_GCMARKER_EXCEPTION_CODE to fix Windows build error.

This commit removes PALAPI attributes from remaining callback types (PHARDWARE_EXCEPTION_HANDLER, PHARDWARE_EXCEPTION_SAFETY_CHECK_FUNCTION) to make it consistent.

@parjong parjong changed the title Remove PALAPI attribute from PAL Callback Remove PALAPI attribute from callback types Jan 24, 2017
@parjong
Copy link
Copy Markdown
Author

parjong commented Jan 24, 2017

@jkotas @janvorli Please take a look.

@jkotas
Copy link
Copy Markdown
Member

jkotas commented Jan 24, 2017

What are the "Windows ports" ?

@parjong
Copy link
Copy Markdown
Author

parjong commented Jan 24, 2017

I revised comment. (I mean all Windows builds).

@jkotas jkotas merged commit 3a0a766 into dotnet:master Jan 24, 2017
@parjong parjong deleted the fix/remove_PALAPI branch January 24, 2017 06:08
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants