This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Make SpinLock.TryEnter(ref bool) fail faster#9224
Merged
Merged
Conversation
benaadams
reviewed
Jan 31, 2017
| { | ||
| TryEnter(0, ref lockTaken); | ||
| int observedOwner = m_owner; | ||
| if ((observedOwner & LOCK_ID_DISABLE_MASK) == 0 | lockTaken) |
Member
There was a problem hiding this comment.
Didn't realise you could bitwise a bool 😄
Member
|
LGTM and the trade off is a good one |
stephentoub
changed the title
One uses SpinLock.TryEnter(ref bool) when they want to do a quick test to either acquire the lock or know it's held by someone else. We can make the latter path much faster so that it fails faster.
stephentoub
force-pushed
the
spinlock_tryenter_perf
branch
from
0e0ee01 to
7ee26ae
Compare
jkotas
approved these changes
Jan 31, 2017
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…nter_perf Make SpinLock.TryEnter(ref bool) fail faster Commit migrated from dotnet/coreclr@93afcb5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One uses SpinLock.TryEnter(ref bool) when they want to do a quick test to either acquire the lock or know it's held by someone else. We can make the latter path much faster so that it fails faster.
With this change, TryEnter(ref bool) on an already held SpinLock is ~3.2x faster than before. It looks like there may be a small ~2-3% regression when the lock isn't already held, but it's hard to say for sure.
cc: @jkotas, @benaadams, @kouvel