Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Update BitConverter from CoreFX #9788

Merged
jkotas merged 2 commits into from
Feb 26, 2017
Merged

Update BitConverter from CoreFX #9788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b185628
Update BitConverter from CoreFX
jkotas Feb 25, 2017
86b7c9e
Use ThrowHelper
jkotas Feb 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/mscorlib/corefx/SR.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,4 +815,19 @@ internal static string Arg_UnauthorizedAccessException
{
get { return Environment.GetResourceString("Arg_UnauthorizedAccessException"); }
}

internal static string ArgumentOutOfRange_GenericPositive
{
get { return Environment.GetResourceString("ArgumentOutOfRange_GenericPositive"); }
Copy link
Copy Markdown
Member

@stephentoub stephentoub Feb 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Not for this PR, but at some point subsequently we might want to go through and replace all of this strings with nameof, e.g.

using static Environment;
...
internal static string ArgumentOutOfRange_GenericPositive => GetResourceString(nameof(ArgumentOutOfRange_GenericPositive);

Copy link
Copy Markdown
Member Author

@jkotas jkotas Feb 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan is switch this file to be auto-generated like everywhere else(https://github.com/dotnet/coreclr/issues/9474)

Copy link
Copy Markdown
Member

@stephentoub stephentoub Feb 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better.

}

internal static string ArgumentOutOfRange_LengthTooLarge
{
get { return Environment.GetResourceString("ArgumentOutOfRange_LengthTooLarge"); }
}

internal static string Arg_ArrayPlusOffTooSmall
{
get { return Environment.GetResourceString("Arg_ArrayPlusOffTooSmall"); }
}
}
Loading