This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Use ESTABLISHER_FRAME_POINTER_IS_CALLER_SP#9814
Merged
janvorli merged 7 commits intoMar 1, 2017
Merged
Conversation
Author
parjong
changed the title
parjong
changed the title
Author
|
@janvorli Please take a look. |
janvorli
suggested changes
Feb 28, 2017
Member
janvorli
left a comment
janvorli
left a comment
There was a problem hiding this comment.
I am sorry for the delay, I have had my comment as a pending one and forgotten to push the "Submit review"
| // This has been confirmed by AaronGi from the kernel team for Windows. | ||
| // | ||
| // For x86/Linux, RtlVirtualUnwind sets EstablisherFrame as Caller-SP. | ||
| #define ESTABLISHER_FRAME_POINTER_IS_CALLER_SP |
Member
There was a problem hiding this comment.
The "frame pointer" in the symbol name is misleading, since it doesn't mean "Fp" register on ARM, which is the frame pointer. So I would rather name it ESTABLISHER_FRAME_ADDRESS_IS_CALLER_SP.
Author
There was a problem hiding this comment.
Thanks for comment. I'll update PR as you suggested.
jorive
pushed a commit
to guhuro/coreclr
that referenced
this pull request
May 4, 2017
* [x86/Linux] Introduce ESTABLISHER_FRAME_ADDRESS_IS_CALLER_SP
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…r#9814) * [x86/Linux] Introduce ESTABLISHER_FRAME_ADDRESS_IS_CALLER_SP Commit migrated from dotnet/coreclr@6ed351c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exceptionhandling.cpp contains several code fragments that are valid when Establisher Frame Pointer is same as Caller SP, but these fragments are explicitly ifdefed by TARGET_XXX.
This commit introduces ESTABLISHER_FRAME_POINTER_IS_CALLER_SP to annotate such code fragments, and use it to ifdef them (instead of explicitly using TARGET_XXX).