Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Specify Xunit.PlatformID where ambiguous in dev/api tests#10158

Merged
dagood merged 1 commit into
dotnet:dev/apifrom
dagood:xunit-platformid
Jul 19, 2016
Merged

Specify Xunit.PlatformID where ambiguous in dev/api tests#10158
dagood merged 1 commit into
dotnet:dev/apifrom
dagood:xunit-platformid

Conversation

@dagood
Copy link
Copy Markdown
Member

@dagood dagood commented Jul 19, 2016

When the build pipeline runs build-tests.cmd for the dev/api branch it hits these errors (taken from one leg, but they appear to all be the same):

BasicEventSourceTest\TestsEventSourceLifetime.cs(23,27): error CS0104: 'PlatformID' is an ambiguous reference between 'System.PlatformID' and 'Xunit.PlatformID' [D:\A\_work\3\s\src\System.Diagnostics.Tracing\tests\System.Diagnostics.Tracing.Tests.csproj]
System\Threading\WaitHandleTests.cs(87,38): error CS0117: 'PlatformID' does not contain a definition for 'Windows' [D:\A\_work\3\s\src\System.Runtime\tests\System.Runtime.Tests.csproj]
System\GCTests.cs(401,38): error CS0117: 'PlatformID' does not contain a definition for 'Windows' [D:\A\_work\3\s\src\System.Runtime\tests\System.Runtime.Tests.csproj]
System\TimeZoneInfoTests.cs(1674,38): error CS0117: 'PlatformID' does not contain a definition for 'AnyUnix' [D:\A\_work\3\s\src\System.Runtime\tests\System.Runtime.Tests.csproj]
System\TimeZoneInfoTests.cs(1697,38): error CS0117: 'PlatformID' does not contain a definition for 'AnyUnix' [D:\A\_work\3\s\src\System.Runtime\tests\System.Runtime.Tests.csproj]
System\TimeZoneInfoTests.cs(1721,38): error CS0117: 'PlatformID' does not contain a definition for 'AnyUnix' [D:\A\_work\3\s\src\System.Runtime\tests\System.Runtime.Tests.csproj]
System\TimeZoneInfoTests.cs(1838,38): error CS0117: 'PlatformID' does not contain a definition for 'AnyUnix' [D:\A\_work\3\s\src\System.Runtime\tests\System.Runtime.Tests.csproj]

System.PlatformID was introduced in #9851, and some references to Xunit.PlatformID were changed to explicitly reference the xunit one, but not these. I haven't been able to track down yet why this error happens in the pipeline but not CI or local builds.

There are many build-tests legs in the pipeline so I'm working on confirming that these are the only ambiguous references.

/cc @danmosemsft @stephentoub

@stephentoub
Copy link
Copy Markdown
Member

LGTM

@dagood
Copy link
Copy Markdown
Member Author

dagood commented Jul 19, 2016

I went through the build legs and the errors are all the same.

@dagood
Copy link
Copy Markdown
Member Author

dagood commented Jul 19, 2016

It looks like those ARM emulator tests are flaky--failures have happened in other PRs too: umount: /opt/linux-arm-emulator-root/dev: device is busy.. Everything else passed, so merging.

@dagood dagood merged commit 3d5e79e into dotnet:dev/api Jul 19, 2016
@dagood dagood deleted the xunit-platformid branch July 19, 2016 23:43
@karelz karelz modified the milestone: 1.2.0 Dec 3, 2016
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Specify Xunit.PlatformID where ambiguous in dev/api tests

Commit migrated from dotnet/corefx@3d5e79e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants