This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Specify Xunit.PlatformID where ambiguous in dev/api tests#10158
Merged
Conversation
Member
|
LGTM |
Member
Author
|
I went through the build legs and the errors are all the same. |
Member
Author
|
It looks like those ARM emulator tests are flaky--failures have happened in other PRs too: |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Specify Xunit.PlatformID where ambiguous in dev/api tests Commit migrated from dotnet/corefx@3d5e79e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the build pipeline runs
build-tests.cmdfor the dev/api branch it hits these errors (taken from one leg, but they appear to all be the same):System.PlatformIDwas introduced in #9851, and some references toXunit.PlatformIDwere changed to explicitly reference the xunit one, but not these. I haven't been able to track down yet why this error happens in the pipeline but not CI or local builds.There are many build-tests legs in the pipeline so I'm working on confirming that these are the only ambiguous references.
/cc @danmosemsft @stephentoub