Update CoreClr, CoreFx, External, ProjectNTfs to beta-24515-02, beta-devapi-24515-01, beta-24514-00, beta-24515-00, respectively (master)#11706
Conversation
|
@adityamandaleeka, another seg fault on CentOS. Do you want me to flag all of these for you I see, or do you have it covered via other means? |
dotnet-bot
changed the title
dotnet-bot
force-pushed
the
master-UpdateDependencies
branch
from
75b97d8 to
0bd0677
Compare
|
I'll take care of this update. |
|
CC myself @tarekgh to get the news about this one. |
dotnet-bot
force-pushed
the
master-UpdateDependencies
branch
from
0bd0677 to
5b95c65
Compare
dotnet-bot
changed the title
dotnet-bot
force-pushed
the
master-UpdateDependencies
branch
from
5b95c65 to
2c982f0
Compare
…devapi-24515-01, beta-24514-00, beta-24515-00, respectively
joperezr
force-pushed
the
master-UpdateDependencies
branch
2 times, most recently
from
59fe959 to
3b61b45
Compare
|
CI is failing due to a bug I introduced to coreclr String class. I'm fixing that with PR dotnet/coreclr#7212. Once that is merged and a new coreclr package is pushed, I'll fix this PR and merge it. |
joperezr
force-pushed
the
master-UpdateDependencies
branch
from
3b61b45 to
aee6588
Compare
|
I don't see any test failures related to the string class. I do see other errors like ApiCompat issues and such. Why do you think the string change is causing this issue? Are we also going to change from beta-devapi to beta? |
|
@weshaggard I removed my change from this PR which uses the right (beta as opposed to beta-devapi) versions and that is also where the System.Runtime.Extensions were failing. The reason I removed my change is so that dotnet-bot can update this PR once a new version of coreclr is available, since if my commit is there, it won't try to update the PR. Once my coreclr PR is merged and a new package is produced, dotnet-bot will update this PR and I'll re-add my change back to use the right versions and CI should be green. |
|
@weshaggard this is one of the builds with my change and you can see how the only thing that failed there was System.Runtime.Extensions tests with the cannot find method exception for System.String.Split(Char) |
|
Couldn't update this pull request: Head commit committer 'Jose Perez Rodriguez' is not 'dotnet-bot' |
apparently it didn't work even with removing my change. I'll update this PR once coreclr is available. |
|
Couldn't update this pull request: Head commit committer 'Jose Perez Rodriguez' is not 'dotnet-bot' |
|
Looks like coreclr version beta-24516-01 still doesn't have my changes. Will wait for next one. |
Will close the PR in the meantime. |
7 participants
/cc @dotnet/corefx-contrib