FrameworkName: Cache the string.Split char[] separator

[justinvp]

Two commits for easier review, preferably merged as separate commits:

1. Cleaned up the formatting to match the CoreFX coding style while making changes in this file.
2. Modified the call to string.Split to use a cached separator array.

(I checked the test coverage and it's 100% for both line and branch coverage).

cc: @stephentoub, @weshaggard, @joperezr

[weshaggard]

LGTM

[justinvp]

@weshaggard, if CoreFX can call the new Split methods in S.P.CoreLib, then is this PR (other than the formatting cleanup) unnecessary?

[weshaggard]

@justinvp not all the builds in corefx can call the new API. Only the builds that are targeting .NET Core. For things targeting .NET Native or .NET Framework they still cannot call that new API yet. So at best we would have to #ifdef this code and I don't think that is worth it at this point.

[justinvp]

@weshaggard, ah, ok. Thanks for the explanation.

[justinvp]

@dotnet-bot Test Innerloop Ubuntu14.04 Release Build and Test please ("The build timed out, or was forcibly aborted after reaching the maximum length")

[stephentoub]

@mmitche, http://dotnet-ci.cloudapp.net/job/dotnet_corefx/job/master/job/ubuntu14.04_release_prtest/229/ is another case where the log shows that there were no hung test suites, but the build was aborted after 2 hours.

[stephentoub]

Thanks, Justin.

[mmitche]

I think these are msbuild failures, perhaps similar to what we saw before?

Msbuild was running. This is what it printed as it was forced to shutdown. How can we investigate this?

/mnt/j/workspace/dotnet_corefx/master/ubuntu14.04_release_prtest/Tools/Microsoft.Common.CurrentVersion.targets(3812,5): error MSB3030: Could not copy the file "/mnt/j/workspace/dotnet_corefx/master/ubuntu14.04_release_prtest/bin/obj/Unix.AnyCPU.Release/System.Net.NameResolution.Unit.Tests/System.Net.NameResolution.Unit.Tests.dll" because it was not found. [/mnt/j/workspace/dotnet_corefx/master/ubuntu14.04_release_prtest/src/System.Net.NameResolution/tests/UnitTests/System.Net.NameResolution.Unit.Tests.csproj]