This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Make 1.1 API netcoreapp1.1-specific#11886
Merged
ericstj merged 2 commits intoSep 21, 2016
Merged
Conversation
Member
|
YES! |
Member
Author
|
Looks like the tests need fixing... Will follow up. |
weshaggard
approved these changes
Sep 19, 2016
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
LGTM (assuming tests are working and CI is green)
ericstj
force-pushed
the
netcoreapp1.1-specific-API
branch
from
0468c23 to
6b799df
Compare
The version for Regex was downgraded when I moved the API to netcoreapp instead of netstandard. This caused a failure in CI because the Linq.Expression tests were building against packages (which had the higher version) but running against live bits; due to "TestWithLocalLibraries" used in the CI. Temporarily build this test against the live bits. This can be removed with the next package update.
Member
Author
|
@dotnet-bot test Innerloop CentOS7.1 Release Build and Test |
weshaggard
reviewed
Sep 20, 2016
| <Name>System.Linq.Expressions</Name> | ||
| </ProjectReference> | ||
| <!-- temporarily compile against the live build of RegularExpressions to handle assembly-version change --> | ||
| <ProjectReference Include="..\..\System.Text.RegularExpressions\pkg\System.Text.RegularExpressions.pkgproj"/> |
Member
There was a problem hiding this comment.
Can you please be sure to have a issue tracking the update of this in the release branch?
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API was previously added to InteropServices and RegEx as
netstandard1.6.Both of these packages are part of NETStandard.Library so placing the API in a netstandard folder commits that API to the standard. Since this is brand-new API that is not yet implemented anywhere but .NET Core (and not even baked) we shouldn't be committing it to the standard.
This change moves the new API to a netcoreapp1.1 specific reference assembly.
Replaces #11272.
/cc @weshaggard