This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Ensure that netcore50 won't be broken by directly referencing S.P.CoreLib in facades#12269
Merged
jkotas merged 1 commit intodotnet:masterfrom Oct 1, 2016
Merged
Ensure that netcore50 won't be broken by directly referencing S.P.CoreLib in facades#12269jkotas merged 1 commit intodotnet:masterfrom
jkotas merged 1 commit intodotnet:masterfrom
Conversation
Member
jkotas
commented
Oct 1, 2016
jkotas
commented
- Update System.Diagnostics.StackTrace to netstandard1.7
- Disable netcore50 builds that would get broken
Member
Author
|
Prep-work for #12187 |
Member
Author
|
@weshaggard PTLA |
weshaggard
reviewed
Oct 1, 2016
| }, | ||
| "netstandard1.7": { | ||
| "dependencies": { | ||
| "Microsoft.TargetingPack.Private.CoreCLR": "1.2.0-beta-24530-04" |
Member
There was a problem hiding this comment.
Can remove the netcore50 section as well.
weshaggard
reviewed
Oct 1, 2016
| @@ -7,9 +7,6 @@ | |||
| <Project Include="System.Reflection.Emit.ILGeneration.csproj"> | |||
Member
There was a problem hiding this comment.
Feel free to delete the commented out net46 configuration.
weshaggard
reviewed
Oct 1, 2016
| @@ -7,9 +7,6 @@ | |||
| <Project Include="System.Reflection.Emit.Lightweight.csproj"> | |||
weshaggard
reviewed
Oct 1, 2016
| @@ -7,9 +7,6 @@ | |||
| <Project Include="System.Reflection.Emit.csproj"> | |||
| <TargetGroup>net46</TargetGroup> | |||
weshaggard
reviewed
Oct 1, 2016
| @@ -8,9 +8,6 @@ | |||
| <TargetGroup>net46</TargetGroup> | |||
Member
There was a problem hiding this comment.
I would clean out the other commented out builds here (net46 and netcore50aot).
weshaggard
reviewed
Oct 1, 2016
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
A few more things to clean-up otherwise looks good.
jkotas
force-pushed
the
netcore50
branch
5 times, most recently
from
5fb0dbe to
870fea0
Compare
…eLib in facades - Update System.Diagnostics.StackTrace to netstandard1.7 - Disable netcore50 builds that would get broken
Member
Author
|
SegFault in System.IO.FileSystem.Watcher.Tests on OSX. Opened #12276 |
Member
Author
|
@dotnet-bot test Innerloop OSX Debug Build and Test please |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…eLib in facades (dotnet/corefx#12269) - Update System.Diagnostics.StackTrace to netstandard1.7 - Disable netcore50 builds that would get broken Commit migrated from dotnet/corefx@eb94e8f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.