This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix ordering of test builds files#12312
Merged
joperezr merged 2 commits intodotnet:masterfrom Oct 5, 2016
Merged
Conversation
Member
Author
|
@dotnet-bot test Innerloop CentOS7.1 Release Build and Test please (infra error: failure to start run) |
Member
|
Seems reasonable, but you have merge conflicts now... |
joperezr
force-pushed
the
FixBuildsOrdering
branch
from
1169e1c to
e448baf
Compare
Member
|
The project ordering looks good thanks. Can I add one more clean-up to your tool? In particular can we have a consistent order to the metadata items? I think TargetGroup, OSGroup, TestTFMs seems like the most consistent and reasonable order. |
joperezr
force-pushed
the
FixBuildsOrdering
branch
from
0c4b91b to
b565022
Compare
Member
Author
done in 0cb490c |
joperezr
force-pushed
the
FixBuildsOrdering
branch
2 times, most recently
from
3604850 to
0cb490c
Compare
joperezr
force-pushed
the
FixBuildsOrdering
branch
from
0cb490c to
8cbdf88
Compare
Member
|
Thanks @joperezr |
macrogreg
pushed a commit
to open-telemetry/opentelemetry-dotnet-instrumentation
that referenced
this pull request
Sep 24, 2020
Fix ordering of test builds files Commit migrated from dotnet/corefx@a799d84
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix ordering of test builds files Commit migrated from dotnet/corefx@a799d84
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @weshaggard
This is addressing some post-merge feedback for #12241 . Wes, please let me know if this ordering makes sense and is what you expected. Ordering algorithm I used was:
itemgroup.Items.OrderBy(i => i.ItemType).ThenByDescending(i => i.Include).ThenBy(i => i.Metadata.Count);