-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Add System.SystemException derivations #12351
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System; | ||
| using System.Runtime.Serialization; | ||
|
|
||
| // TODO: remove this stub once System.SystemException is added to UWP | ||
| namespace System { | ||
|
|
||
| [Serializable] | ||
| [System.Runtime.InteropServices.ComVisible(true)] | ||
| public class SystemException : Exception | ||
| { | ||
| public SystemException() | ||
| : base("System error.") { | ||
| } | ||
|
|
||
| public SystemException(String message) | ||
| : base(message) { | ||
| } | ||
|
|
||
| public SystemException(String message, Exception innerException) | ||
| : base(message, innerException) { | ||
| } | ||
|
|
||
| protected SystemException(SerializationInfo info, StreamingContext context) : base(info, context) { | ||
| } | ||
| } | ||
| } | ||
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,4 +66,5 @@ MembersMustExist : Member 'System.Globalization.TextInfo.LCID.get()' does not ex | |
| MembersMustExist : Member 'System.Globalization.TextInfo.MacCodePage.get()' does not exist in the implementation but it does exist in the contract. | ||
| MembersMustExist : Member 'System.Globalization.TextInfo.OEMCodePage.get()' does not exist in the implementation but it does exist in the contract. | ||
| MembersMustExist : Member 'System.Globalization.TextInfo.ReadOnly(System.Globalization.TextInfo)' does not exist in the implementation but it does exist in the contract. | ||
| MembersMustExist : Member 'System.Globalization.TextInfo.ToTitleCase(System.String)' does not exist in the implementation but it does exist in the contract. | ||
| MembersMustExist : Member 'System.Globalization.TextInfo.ToTitleCase(System.String)' does not exist in the implementation but it does exist in the contract. | ||
| CannotRemoveBaseTypeOrInterface : Type 'System.Globalization.CultureNotFoundException' does not inherit from base type 'System.SystemException' in the implementation but it does in the contract. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there an issue on CoreRT to follow up on this one and similar changes?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Created dotnet/corert#2040 |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -68,6 +68,7 @@ | |
|
|
||
| <!-- Common --> | ||
| <ItemGroup Condition="'$(TargetGroup)' == 'uap101aot'"> | ||
| <Compile Include="$(CommonPath)\System\SystemException.cs" /> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't System.SystemException need to be in S.P.CorLib and exposed through a contract, say S.Runtime??
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From my understanding, that's what's supposed to happen. This, however, is just a temporary stub for |
||
| <Compile Include="$(CommonPath)\System\HResults.cs"> | ||
| <Link>Common\System\HResults.cs</Link> | ||
| </Compile> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
| <PropertyGroup> | ||
| <OutputType>Library</OutputType> | ||
| <NuGetTargetMoniker>.NETStandard,Version=v1.7</NuGetTargetMoniker> | ||
| <PackageTargetFramework>netstandard1.7;uap10.1</PackageTargetFramework> | ||
| <PackageTargetFramework Condition="'$(TargetGroup)' == ''">netstandard1.7;uap10.1</PackageTargetFramework> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for fixing this! |
||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Compile Include="System.Resources.ResourceManager.cs" /> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| CannotRemoveBaseTypeOrInterface : Type 'System.Runtime.Serialization.SerializationException' does not inherit from base type 'System.SystemException' in the implementation but it does in the contract. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,6 +56,10 @@ | |
| <ItemGroup> | ||
| <None Include="project.json" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition="'$(TargetGroup)' == ''"> | ||
| <!-- TODO: remove this P2P reference once new packages are produced and updated --> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Is there an issue tracking this?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe there is an issue open for removing all P2P references with these TODO labels. Is that correct @joperezr?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems like we should have a single issue tracking cleaning up P2P's rather than lots of them. We al;ready have #10688, #12531, ... and I imagine one person can make a single pass after NS2.0 work settles down next month. |
||
| <ProjectReference Include="..\..\System.Runtime\ref\System.Runtime.csproj" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <EmbeddedResource Include="Resources\$(AssemblyName).rd.xml" /> | ||
| </ItemGroup> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue tracking this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created issue https://github.com/dotnet/corefx/issues/12550