Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/Microsoft.Private.PackageBaseline/packageIndex.json
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,9 @@
"AssemblyVersionInPackageVersion": {
"4.0.0.0": "4.4.0",
"4.0.2.0": "4.3.0",
"4.0.3.0": "4.4.0"
"4.0.3.0": "4.4.0",
"4.0.1.0": "4.4.0",
"4.1.0.0": "4.4.0"
}
},
"runtime.any.System.Runtime": {
Expand Down Expand Up @@ -351,7 +353,8 @@
],
"BaselineVersion": "4.4.0",
"AssemblyVersionInPackageVersion": {
"4.0.0.0": "4.4.0"
"4.0.0.0": "4.4.0",
"4.1.0.0": "4.4.0"
}
},
"runtime.aot.System.Runtime": {
Expand Down
30 changes: 30 additions & 0 deletions src/Common/src/System/SystemException.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System;
using System.Runtime.Serialization;

// TODO: remove this stub once System.SystemException is added to UWP
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO [](start = 3, length = 4)

Is there an issue tracking this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace System {

[Serializable]
[System.Runtime.InteropServices.ComVisible(true)]
public class SystemException : Exception
{
public SystemException()
: base("System error.") {
}

public SystemException(String message)
: base(message) {
}

public SystemException(String message, Exception innerException)
: base(message, innerException) {
}

protected SystemException(SerializationInfo info, StreamingContext context) : base(info, context) {
}
}
}
14 changes: 0 additions & 14 deletions src/System.Globalization/ref/4.0.10/System.Globalization.depproj

This file was deleted.

12 changes: 0 additions & 12 deletions src/System.Globalization/ref/4.0.10/project.json

This file was deleted.

1 change: 0 additions & 1 deletion src/System.Globalization/ref/System.Globalization.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" />
<PropertyGroup>
<AssemblyVersion>4.1.0.0</AssemblyVersion>
<OutputType>Library</OutputType>
<NuGetTargetMoniker>.NETStandard,Version=v1.7</NuGetTargetMoniker>
<PackageTargetFramework>netstandard1.7;uap10.1</PackageTargetFramework>
Expand Down
3 changes: 2 additions & 1 deletion src/System.Globalization/src/ApiCompatBaseline.uap101aot.txt
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,5 @@ MembersMustExist : Member 'System.Globalization.TextInfo.LCID.get()' does not ex
MembersMustExist : Member 'System.Globalization.TextInfo.MacCodePage.get()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'System.Globalization.TextInfo.OEMCodePage.get()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'System.Globalization.TextInfo.ReadOnly(System.Globalization.TextInfo)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'System.Globalization.TextInfo.ToTitleCase(System.String)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'System.Globalization.TextInfo.ToTitleCase(System.String)' does not exist in the implementation but it does exist in the contract.
CannotRemoveBaseTypeOrInterface : Type 'System.Globalization.CultureNotFoundException' does not inherit from base type 'System.SystemException' in the implementation but it does in the contract.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue on CoreRT to follow up on this one and similar changes?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 change: 0 additions & 1 deletion src/System.Globalization/src/System.Globalization.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))\dir.props" />
<PropertyGroup>
<AssemblyName>System.Globalization</AssemblyName>
<ContractProject Condition="'$(AssemblyVersion)'!='4.1.0.0'">../ref/4.0.10/System.Globalization.depproj</ContractProject>
<IsPartialFacadeAssembly>true</IsPartialFacadeAssembly>
<NuGetTargetMoniker Condition="'$(TargetGroup)' == ''">.NETStandard,Version=v1.7</NuGetTargetMoniker>
<PackageTargetFramework Condition="'$(TargetGroup)' == ''">netstandard1.7;uap10.1</PackageTargetFramework>
Expand Down
2 changes: 1 addition & 1 deletion src/System.Globalization/src/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"net463": {
"dependencies": {
"Microsoft.TargetingPack.NETFramework.v4.6": "1.0.1"
"Microsoft.TargetingPack.NETFramework.v4.6.2": "1.0.1"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/System.IO/ref/System.IO.cs
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ public EndOfStreamException() { }
public EndOfStreamException(string message) { }
public EndOfStreamException(string message, System.Exception innerException) { }
}
public sealed partial class InvalidDataException : System.Exception
public sealed partial class InvalidDataException : System.SystemException
{
public InvalidDataException() { }
public InvalidDataException(string message) { }
Expand Down
5 changes: 4 additions & 1 deletion src/System.IO/src/ApiCompatBaseline.uap101aot.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,7 @@ MembersMustExist : Member 'System.IO.Stream.CreateWaitHandle()' does not exist i
MembersMustExist : Member 'System.IO.Stream.ObjectInvariant()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'System.IO.Stream.Synchronized(System.IO.Stream)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'System.IO.TextReader.Synchronized(System.IO.TextReader)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'System.IO.TextWriter.Synchronized(System.IO.TextWriter)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'System.IO.TextWriter.Synchronized(System.IO.TextWriter)' does not exist in the implementation but it does exist in the contract.
CannotRemoveBaseTypeOrInterface : Type 'System.IO.EndOfStreamException' does not inherit from base type 'System.SystemException' in the implementation but it does in the contract.
CannotRemoveBaseTypeOrInterface : Type 'System.IO.FileNotFoundException' does not inherit from base type 'System.SystemException' in the implementation but it does in the contract.
CannotRemoveBaseTypeOrInterface : Type 'System.IO.IOException' does not inherit from base type 'System.SystemException' in the implementation but it does in the contract.
1 change: 1 addition & 0 deletions src/System.IO/src/System.IO.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@

<!-- Common -->
<ItemGroup Condition="'$(TargetGroup)' == 'uap101aot'">
<Compile Include="$(CommonPath)\System\SystemException.cs" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't System.SystemException need to be in S.P.CorLib and exposed through a contract, say S.Runtime??

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, that's what's supposed to happen. This, however, is just a temporary stub for System.SystemException for UWP. Issue https://github.com/dotnet/corefx/issues/12550 is tracking this.

<Compile Include="$(CommonPath)\System\HResults.cs">
<Link>Common\System\HResults.cs</Link>
</Compile>
Expand Down
2 changes: 1 addition & 1 deletion src/System.IO/src/System/IO/InvalidDataException.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace System.IO
{
public sealed class InvalidDataException : Exception
public sealed class InvalidDataException : SystemException
{
public InvalidDataException()
: base(SR.GenericInvalidData)
Expand Down
2 changes: 1 addition & 1 deletion src/System.Net.Security/ref/System.Net.Security.cs
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public override void Write(byte[] buffer, int offset, int count) { }
}
namespace System.Security.Authentication
{
public partial class AuthenticationException : System.Exception
public partial class AuthenticationException : System.SystemException
{
public AuthenticationException() { }
public AuthenticationException(string message) { }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace System.Security.Authentication
/// The authentication process can be retried with different parameters subject to
/// remote party willingness of accepting that.
/// </summary>
public class AuthenticationException : Exception
public class AuthenticationException : SystemException
{
public AuthenticationException() { }
public AuthenticationException(string message) : base(message) { }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace System.Runtime.Serialization
{
public class SerializationException : Exception
public class SerializationException : SystemException
{
public SerializationException() { }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<PropertyGroup>
<OutputType>Library</OutputType>
<NuGetTargetMoniker>.NETStandard,Version=v1.7</NuGetTargetMoniker>
<PackageTargetFramework>netstandard1.7;uap10.1</PackageTargetFramework>
<PackageTargetFramework Condition="'$(TargetGroup)' == ''">netstandard1.7;uap10.1</PackageTargetFramework>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

</PropertyGroup>
<ItemGroup>
<Compile Include="System.Resources.ResourceManager.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace System.Resources
{
public class MissingManifestResourceException : Exception
public class MissingManifestResourceException : SystemException
{
public MissingManifestResourceException()
: base(SR.Arg_MissingManifestResourceException)
Expand Down
23 changes: 11 additions & 12 deletions src/System.Resources.ResourceManager/src/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,22 @@
"Microsoft.TargetingPack.Private.CoreCLR": "1.2.0-beta-24617-03"
}
},
"net463": {
"dependencies": {
"Microsoft.TargetingPack.NETFramework.v4.6": "1.0.1"
}
},
"uap10.1": {
"dependencies": {
"Microsoft.NETCore.Platforms": "1.0.1",
"Microsoft.TargetingPack.Private.NETNative": "1.1.0-beta-24607-01",
"Microsoft.TargetingPack.Private.WinRT": "1.0.1",
"System.Diagnostics.Debug": "4.0.0",
"System.Diagnostics.Tools": "4.0.0",
"System.Diagnostics.Tracing": "4.0.0",
"System.Globalization": "4.0.0",
"System.Reflection": "4.0.10",
"System.Runtime": "4.0.20",
"System.Threading": "4.0.10"
"System.Diagnostics.Debug": "4.4.0-beta-24617-03",
"System.Diagnostics.Tools": "4.4.0-beta-24617-03",
"System.Diagnostics.Tracing": "4.4.0-beta-24617-03",
"System.Reflection": "4.4.0-beta-24617-03",
"System.Runtime": "4.4.0-beta-24617-03",
"System.Threading": "4.4.0-beta-24617-03"
}
},
"net463": {
"dependencies": {
"Microsoft.TargetingPack.NETFramework.v4.6.2": "1.0.1"
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

namespace System
{
public sealed partial class DataMisalignedException : System.Exception
public sealed partial class DataMisalignedException : System.SystemException
{
public DataMisalignedException() { }
public DataMisalignedException(string message) { }
Expand Down Expand Up @@ -426,13 +426,13 @@ public InterfaceTypeAttribute(short interfaceType) { }
public InterfaceTypeAttribute(System.Runtime.InteropServices.ComInterfaceType interfaceType) { }
public System.Runtime.InteropServices.ComInterfaceType Value { get { throw null; } }
}
public partial class InvalidComObjectException : System.Exception
public partial class InvalidComObjectException : System.SystemException
{
public InvalidComObjectException() { }
public InvalidComObjectException(string message) { }
public InvalidComObjectException(string message, System.Exception inner) { }
}
public partial class InvalidOleVariantTypeException : System.Exception
public partial class InvalidOleVariantTypeException : System.SystemException
{
public InvalidOleVariantTypeException() { }
public InvalidOleVariantTypeException(string message) { }
Expand Down Expand Up @@ -761,7 +761,7 @@ public MarshalAsAttribute(short unmanagedType) { }
public MarshalAsAttribute(System.Runtime.InteropServices.UnmanagedType unmanagedType) { }
public System.Runtime.InteropServices.UnmanagedType Value { get { throw null; } }
}
public partial class MarshalDirectiveException : System.Exception
public partial class MarshalDirectiveException : System.SystemException
{
public MarshalDirectiveException() { }
public MarshalDirectiveException(string message) { }
Expand All @@ -777,13 +777,13 @@ public sealed partial class PreserveSigAttribute : System.Attribute
{
public PreserveSigAttribute() { }
}
public partial class SafeArrayRankMismatchException : System.Exception
public partial class SafeArrayRankMismatchException : System.SystemException
{
public SafeArrayRankMismatchException() { }
public SafeArrayRankMismatchException(string message) { }
public SafeArrayRankMismatchException(string message, System.Exception inner) { }
}
public partial class SafeArrayTypeMismatchException : System.Exception
public partial class SafeArrayTypeMismatchException : System.SystemException
{
public SafeArrayTypeMismatchException() { }
public SafeArrayTypeMismatchException(string message) { }
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
CannotRemoveBaseTypeOrInterface : Type 'System.Runtime.Serialization.SerializationException' does not inherit from base type 'System.SystemException' in the implementation but it does in the contract.
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@
<ItemGroup>
<None Include="project.json" />
</ItemGroup>
<ItemGroup Condition="'$(TargetGroup)' == ''">
<!-- TODO: remove this P2P reference once new packages are produced and updated -->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO [](start = 9, length = 4)

Is there an issue tracking this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is an issue open for removing all P2P references with these TODO labels. Is that correct @joperezr?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should have a single issue tracking cleaning up P2P's rather than lots of them. We al;ready have #10688, #12531, ... and I imagine one person can make a single pass after NS2.0 work settles down next month.

<ProjectReference Include="..\..\System.Runtime\ref\System.Runtime.csproj" />
</ItemGroup>
<ItemGroup>
<EmbeddedResource Include="Resources\$(AssemblyName).rd.xml" />
</ItemGroup>
Expand Down
Loading