This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add leaveOpen ctor to CryptoStream#12718
Merged
Merged
Conversation
stephentoub
reviewed
Oct 17, 2016
|
|
||
| Assert.Equal(true, output.CanRead); | ||
| } | ||
| #endif |
Member
There was a problem hiding this comment.
Nit: I think elsewhere we've been separating out such tests that depend on new surface area into separate files.
stephentoub
approved these changes
Oct 17, 2016
Member
Author
|
@dotnet-bot test Innerloop Ubuntu14.04 Release Build and Test please (build timeout). FYI @adityamandaleeka and @mmitche |
Contributor
|
Thanks for doing this @bartonjs |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…veOpen_ctor Add leaveOpen ctor to CryptoStream Commit migrated from dotnet/corefx@3dcb746
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
public CryptoStream(Stream, ICryptoTransform, CryptoStreamMode, bool leaveOpen)to the netcoreapp1.1 contract (which will be bumped to 1.2 once support for that version exists).Fixes #1079.
Replaces PR #11587 (thanks, @bbowyersmyth).
cc: @stephentoub @steveharter