This repository was archived by the owner on Jan 23, 2023. It is now read-only.
System.Reflection.DispatchProxy: remove two unnecessary usings#1354
Merged
stephentoub merged 1 commit intodotnet:masterfrom Apr 9, 2015
Merged
System.Reflection.DispatchProxy: remove two unnecessary usings#1354stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
They cause an error on Mono's mcs even though they aren't used by the code (because the corresponding package isn't imported in packages.config).
Contributor
|
Same issue in VS 2013 |
Member
|
Other than actually removing three rather than two usings 😄, LGTM. |
Member
Author
|
It's two namespaces: |
Member
|
😄 |
stephentoub
added a commit
that referenced
this pull request
Apr 9, 2015
System.Reflection.DispatchProxy: remove two unnecessary usings
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…sings System.Reflection.DispatchProxy: remove two unnecessary usings Commit migrated from dotnet/corefx@4dae948
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They cause an error on Mono's mcs even though they aren't used by the code (because the corresponding package isn't imported in packages.config).
Note: I haven't checked if other usings may be unnecessary as well, I think this be left to the codeformatter once it supports doing that.