Add ConcurrentBag Clear APIs#14084
Add ConcurrentBag Clear APIs#14084AlexRadch wants to merge 3 commits intodotnet:masterfrom AlexRadch:ConcurrentBag.Clear
Conversation
|
I do not clear understand Adding APIs Guidelines so test project can be compiled and tested locally in @Priya91 can you help me with config files to add API correctly to pass root build? |
| try | ||
| { | ||
| FreezeBag(ref lockTaken); | ||
|
|
There was a problem hiding this comment.
Nit: var => ThreadLocalList
|
@AlexRadch Can you post the build errors.. |
|
@AlexRadch, it'll probably be easier for you if you wait for @jusinvp to finish with #13828. As part of that he's added the necessary netcoreapp11 support to the project, and once that's there it should be fairly straightforward for you to add these new methods. |
|
@stephentoub Ok. I am waiting when you add netcoreapp11 support to this project. Thanks. |
|
@justinvp's PR is merged for 5 days now - #13828 (comment). The work should be unblocked ... |
|
@AlexRadch do you plan to finish it? |
|
@AlexRadch ping? |
|
Thanks for your work on this, @AlexRadch. Since this has been sitting for a couple of months and needed to be significantly updated based on changes to the target types, I went ahead and took your commits and created a new PR at #15292. |
Implement ConcurrentBag.Clear API. See https://github.com/dotnet/corefx/issues/2338 issue.