Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Add ConcurrentBag Clear APIs#14084

Closed
AlexRadch wants to merge 3 commits intodotnet:masterfrom
AlexRadch:ConcurrentBag.Clear
Closed

Add ConcurrentBag Clear APIs#14084
AlexRadch wants to merge 3 commits intodotnet:masterfrom
AlexRadch:ConcurrentBag.Clear

Conversation

@AlexRadch
Copy link
Copy Markdown

Implement ConcurrentBag.Clear API. See https://github.com/dotnet/corefx/issues/2338 issue.

@AlexRadch
Copy link
Copy Markdown
Author

I do not clear understand Adding APIs Guidelines so test project can be compiled and tested locally in src\System.Collections.Concurrent\tests\ folder but global build return strange errors.

@Priya91 can you help me with config files to add API correctly to pass root build?

try
{
FreezeBag(ref lockTaken);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: var => ThreadLocalList

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@Priya91
Copy link
Copy Markdown
Contributor

Priya91 commented Nov 29, 2016

@AlexRadch Can you post the build errors..

@AlexRadch
Copy link
Copy Markdown
Author

@Priya91 msbuild.err.txt

@stephentoub
Copy link
Copy Markdown
Member

@AlexRadch, it'll probably be easier for you if you wait for @jusinvp to finish with #13828. As part of that he's added the necessary netcoreapp11 support to the project, and once that's there it should be fairly straightforward for you to add these new methods.

@AlexRadch
Copy link
Copy Markdown
Author

@stephentoub Ok. I am waiting when you add netcoreapp11 support to this project. Thanks.

@karelz karelz modified the milestone: 1.2.0 Dec 6, 2016
@karelz
Copy link
Copy Markdown
Member

karelz commented Dec 20, 2016

@justinvp's PR is merged for 5 days now - #13828 (comment). The work should be unblocked ...

@karelz
Copy link
Copy Markdown
Member

karelz commented Jan 4, 2017

@AlexRadch do you plan to finish it?

@karelz
Copy link
Copy Markdown
Member

karelz commented Jan 11, 2017

@AlexRadch ping?

@stephentoub
Copy link
Copy Markdown
Member

Thanks for your work on this, @AlexRadch. Since this has been sitting for a couple of months and needed to be significantly updated based on changes to the target types, I went ahead and took your commits and created a new PR at #15292.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants