Expose String.Trim overloads that take a single char#15334
Expose String.Trim overloads that take a single char#15334weshaggard merged 1 commit intodotnet:masterfrom
Conversation
|
@justinvp it looks like there is an APICompat failure with this change. Do you know if the actual implementation (from CoreCLR) has been ingested into CoreFx? If not, that could explain the failures. |
|
@AlexGhiondea, dotnet/coreclr#9009 hasn't been merged yet and the changes haven't made their way to corefx yet. |
|
Blocked on coreclr change. |
| public System.String ToUpper(System.Globalization.CultureInfo culture) { throw null; } | ||
| public string ToUpperInvariant() { throw null; } | ||
| public string Trim() { throw null; } | ||
| #if netcoreapp11 |
There was a problem hiding this comment.
I think we do'nt need this anymore. @weshaggard ? (I can't find that PR where you explained this alreadY)
There was a problem hiding this comment.
I thought I saw that explanation in another PR as well, but there were other netcoreapp11 ifdefs in this file, so I just matched that here.
There was a problem hiding this comment.
Sure, but I likely won't be able to get to it until sometime Wednesday.
|
@dotnet-bot test this please. |
justinvp
force-pushed
the
string_trim_tests
branch
from
38f8276 to
0a03069
Compare
|
@dotnet-bot test Innerloop Windows_NT Release Build and Test |
|
This should be good to merge now. |
Expose String.Trim overloads that take a single char Commit migrated from dotnet/corefx@9f00738
7 participants
Expose and add tests for dotnet/coreclr#9009.
The new tests should compile/run on older platforms that don't have the new overloads yet since the existing overloads are
params. Though, I assume it won't pass CI until the changes to coreclr are available to corefx due to the ref update.Fixes #14337