This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Expose parameterless string.TrimEnd/TrimStart in ref#15476
Merged
Conversation
Contributor
Author
|
@dotnet-bot test Innerloop Windows_NT Debug Build and Test (System.IO.IOException : The process cannot access the file 'C:\Users\dotnet-bot\AppData\Local\Temp\tmp5DAB.tmp' because it is being used by another process.) |
karelz
suggested changes
Jan 25, 2017
Member
karelz
left a comment
karelz
left a comment
There was a problem hiding this comment.
Can you please add tests for the new APIs?
Contributor
Author
@karelz, as I noted in the description, there are already existing tests that cover these APIs. (It worked previously due to the existing params overloads). |
karelz
approved these changes
Jan 25, 2017
Member
karelz
left a comment
karelz
left a comment
There was a problem hiding this comment.
I should read descriptions better, sorry!
Member
|
Thanks @justinvp ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the new parameterless TrimEnd/TrimStart APIs added in dotnet/coreclr#8834.
The existing tests already cover these new APIs:
corefx/src/System.Runtime/tests/System/StringTests.cs
Line 2338 in 9f00738
corefx/src/System.Runtime/tests/System/StringTests.cs
Line 2362 in 9f00738
Fixes #6485