Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[ARM/CI] ARM CI script for arm and armel#15900

Merged
gkhanna79 merged 1 commit into
dotnet:masterfrom
hqueue:arm/ci
Feb 16, 2017
Merged

[ARM/CI] ARM CI script for arm and armel#15900
gkhanna79 merged 1 commit into
dotnet:masterfrom
hqueue:arm/ci

Conversation

@hqueue
Copy link
Copy Markdown
Member

@hqueue hqueue commented Feb 7, 2017 •
edited
Loading

ARM CI for arm and armel.
This CI script tests followings for ubuntu.14.04-arm, ubuntu.16.04-arm and tizen.4.0.0-armel.

  1. Construct RootFS for ubuntu.14.04-arm, ubuntu.16.04-arm and tizen.4.0.0-armel.
  2. Cross build corefx using RootFS for ubuntu.14.04-arm, ubuntu.16.04-arm and tizen.4.0.0-armel. Release and Debug build are available.
  3. Above tasks are performed inside Docker image.

Related issues:
https://github.com/dotnet/coreclr/issues/9273
https://github.com/dotnet/core-setup/issues/790

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot help

@dotnet-bot
Copy link
Copy Markdown

dotnet-bot commented Feb 7, 2017

Welcome to the dotnet/corefx Repository

The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR

The following commands are valid for all PRs and repositories.

Click to expand
Comment Phrase Action
@dotnet-bot test this please Re-run all legs. Use sparingly
@dotnet-bot test ci please Generates (but does not run) jobs based on changes to the groovy job definitions in this branch
@dotnet-bot help Print this help message

The following jobs are launched by default for each PR against dotnet/corefx:master.

Click to expand
Comment Phrase Job Launched
@dotnet-bot test Innerloop CentOS7.1 Debug Build and Test Innerloop CentOS7.1 Debug Build and Test
@dotnet-bot test Innerloop CentOS7.1 Release Build and Test Innerloop CentOS7.1 Release Build and Test
@dotnet-bot test Innerloop OSX Debug Build and Test Innerloop OSX Debug Build and Test
@dotnet-bot test Innerloop OSX Release Build and Test Innerloop OSX Release Build and Test
@dotnet-bot test Innerloop PortableLinux Debug Build and Test Innerloop PortableLinux Debug Build and Test
@dotnet-bot test Innerloop PortableLinux Release Build and Test Innerloop PortableLinux Release Build and Test
@dotnet-bot test Vertical uap Build Vertical uap Build
@dotnet-bot test Vertical uapaot Build Vertical uapaot Build
@dotnet-bot test Innerloop Ubuntu14.04 Debug Build and Test Innerloop Ubuntu14.04 Debug Build and Test
@dotnet-bot test Innerloop Ubuntu14.04 Release Build and Test Innerloop Ubuntu14.04 Release Build and Test
@dotnet-bot test Innerloop Windows_NT Debug Build and Test Innerloop Windows_NT Debug Build and Test
@dotnet-bot test Innerloop Windows_NT Release Build and Test Innerloop Windows_NT Release Build and Test

The following optional jobs are available in PRs against dotnet/corefx:master.

Click to expand
Comment Phrase Job Launched
@dotnet-bot test code coverage Queues Code Coverage Windows Debug
@dotnet-bot test innerloop Debian8.4 Debug Queues Innerloop Debian8.4 Debug Build and Test
@dotnet-bot test innerloop Debian8.4 Release Queues Innerloop Debian8.4 Release Build and Test
@dotnet-bot test innerloop Fedora23 Debug Queues Innerloop Fedora23 Debug Build and Test
@dotnet-bot test innerloop Fedora23 Release Queues Innerloop Fedora23 Release Build and Test
@dotnet-bot test innerloop Fedora24 Debug Queues Innerloop Fedora24 Debug Build and Test
@dotnet-bot test innerloop Fedora24 Release Queues Innerloop Fedora24 Release Build and Test
@dotnet-bot test innerloop linuxarmemulator HardFP Debug Queues Innerloop Linux ARM Emulator HardFP Debug Cross Build
@dotnet-bot test innerloop linuxarmemulator HardFP Release Queues Innerloop Linux ARM Emulator HardFP Release Cross Build
@dotnet-bot test innerloop linuxarmemulator SoftFP Debug Queues Innerloop Linux ARM Emulator SoftFP Debug Cross Build
@dotnet-bot test innerloop linuxarmemulator SoftFP Release Queues Innerloop Linux ARM Emulator SoftFP Release Cross Build
@dotnet-bot test code formatter check Queues Code Formatter Check
@dotnet-bot test innerloop OpenSUSE13.2 Debug Queues Innerloop OpenSUSE13.2 Debug Build and Test
@dotnet-bot test innerloop OpenSUSE13.2 Release Queues Innerloop OpenSUSE13.2 Release Build and Test
@dotnet-bot test innerloop OpenSUSE42.1 Debug Queues Innerloop OpenSUSE42.1 Debug Build and Test
@dotnet-bot test innerloop OpenSUSE42.1 Release Queues Innerloop OpenSUSE42.1 Release Build and Test
@dotnet-bot test outerloop CentOS7.1 Debug Queues OuterLoop CentOS7.1 Debug
@dotnet-bot test outerloop CentOS7.1 Release Queues OuterLoop CentOS7.1 Release
@dotnet-bot test outerloop Debian8.4 Debug Queues OuterLoop Debian8.4 Debug
@dotnet-bot test outerloop Debian8.4 Release Queues OuterLoop Debian8.4 Release
@dotnet-bot test outerloop Fedora23 Debug Queues OuterLoop Fedora23 Debug
@dotnet-bot test outerloop Fedora23 Release Queues OuterLoop Fedora23 Release
@dotnet-bot test outerloop Fedora24 Debug Queues OuterLoop Fedora24 Debug
@dotnet-bot test outerloop Fedora24 Release Queues OuterLoop Fedora24 Release
@dotnet-bot test outerloop OpenSUSE13.2 Debug Queues OuterLoop OpenSUSE13.2 Debug
@dotnet-bot test outerloop OpenSUSE13.2 Release Queues OuterLoop OpenSUSE13.2 Release
@dotnet-bot test outerloop OpenSUSE42.1 Debug Queues OuterLoop OpenSUSE42.1 Debug
@dotnet-bot test outerloop OpenSUSE42.1 Release Queues OuterLoop OpenSUSE42.1 Release
@dotnet-bot test outerloop OSX Debug Queues OuterLoop OSX Debug
@dotnet-bot test outerloop OSX Release Queues OuterLoop OSX Release
@dotnet-bot test outerloop PortableLinux Debug Queues OuterLoop PortableLinux Debug
@dotnet-bot test outerloop PortableLinux Release Queues OuterLoop PortableLinux Release
@dotnet-bot test outerloop RHEL7.2 Debug Queues OuterLoop RHEL7.2 Debug
@dotnet-bot test outerloop RHEL7.2 Release Queues OuterLoop RHEL7.2 Release
@dotnet-bot test outerloop Ubuntu14.04 Debug Queues OuterLoop Ubuntu14.04 Debug
@dotnet-bot test outerloop Ubuntu14.04 Release Queues OuterLoop Ubuntu14.04 Release
@dotnet-bot test outerloop Ubuntu16.04 Debug Queues OuterLoop Ubuntu16.04 Debug
@dotnet-bot test outerloop Ubuntu16.04 Release Queues OuterLoop Ubuntu16.04 Release
@dotnet-bot test outerloop Ubuntu16.10 Debug Queues OuterLoop Ubuntu16.10 Debug
@dotnet-bot test outerloop Ubuntu16.10 Release Queues OuterLoop Ubuntu16.10 Release
@dotnet-bot test outerloop Windows 10 Debug Queues OuterLoop Windows 10 Debug
@dotnet-bot test outerloop Windows 10 Release Queues OuterLoop Windows 10 Release
@dotnet-bot test outerloop Windows 7 Debug Queues OuterLoop Windows 7 Debug
@dotnet-bot test outerloop Windows 7 Release Queues OuterLoop Windows 7 Release
@dotnet-bot test outerloop Windows_NT Debug Queues OuterLoop Windows_NT Debug
@dotnet-bot test outerloop Windows_NT Release Queues OuterLoop Windows_NT Release
@dotnet-bot test outerloop Windows Nano 2016 Debug Queues OuterLoop Windows Nano 2016 Debug
@dotnet-bot test outerloop Windows Nano 2016 Release Queues OuterLoop Windows Nano 2016 Release
@dotnet-bot test innerloop RHEL7.2 Debug Queues Innerloop RHEL7.2 Debug Build and Test
@dotnet-bot test innerloop RHEL7.2 Release Queues Innerloop RHEL7.2 Release Build and Test
@dotnet-bot test innerloop Ubuntu16.04 Debug Queues Innerloop Ubuntu16.04 Debug Build and Test
@dotnet-bot test innerloop Ubuntu16.04 Release Queues Innerloop Ubuntu16.04 Release Build and Test
@dotnet-bot test innerloop Ubuntu16.10 Debug Queues Innerloop Ubuntu16.10 Debug Build and Test
@dotnet-bot test innerloop Ubuntu16.10 Release Queues Innerloop Ubuntu16.10 Release Build and Test

Have a nice day!

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot skip test please

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot test innerloop linuxarmemulator SoftFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot skip ci please

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot skip ci please

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot test innerloop linuxarmemulator SoftFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot test innerloop linuxarmemulator HardFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot skip this please

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 7, 2017

@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 14, 2017

@dotnet-bot test innerloop linuxarmemulator armel Release
@dotnet-bot test innerloop linuxarmemulator arm Release

@hqueue hqueue changed the title [WIP][DO NOT MERGE][ARM/CI] Test [ARM/CI] ARM CI script for arm and armel Feb 14, 2017
@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 14, 2017 •
edited
Loading

@gkhanna79 PTAL. I've also updated description of this PR.
I think it's almost ready for ubuntu.14.04-arm, ubuntu.16.04-arm and tizen.4.0.0-armel.

After this script is merged, I think we can update netci.groovy to enable auto-PR tests for ubuntu.14.04-arm, ubuntu.16.04-arm and tizen.4.0.0-armel.
What kind of test are we going to enable ? There are all six test available with this script as follows.

  • Three RID: ubuntu.14.04-arm, ubuntu.16.04-arm, tizen.4.0.0-armel
  • Two build configuration: Release and Debug

gkhanna79
gkhanna79 reviewed Feb 14, 2017
View reviewed changes
Comment thread scripts/arm32_ci_script.sh Outdated
echo 'Optional Arguments:'
echo ' --arm : Build as arm (default)'
echo ' --armel : Build as armel'
echo ' --linuxCodeName=<name> : Linux code name: trusty, xenial (default) and tizen'
Copy link
Copy Markdown
Member

@gkhanna79 gkhanna79 Feb 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is xenial default here and not trusty (as at https://github.com/dotnet/coreclr/blob/master/cross/build-rootfs.sh#L13)? We should keep consistency for the defaults across the board so that it is simple to follow.

Copy link
Copy Markdown
Member Author

@hqueue hqueue Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right, it's more clear to make trusty as defatult.

@gkhanna79
Copy link
Copy Markdown
Member

gkhanna79 commented Feb 14, 2017

Modulo the comment, this looks fine to me. Can you please look into the comment and CI generation failure?

@hqueue hqueue force-pushed the arm/ci branch 2 times, most recently from d2e23e1 to c8e2525 Compare February 15, 2017 02:08
@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 15, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator armel Release
@dotnet-bot test innerloop linuxarmemulator arm Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 15, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 15, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 15, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Release

@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 15, 2017 •
edited
Loading

@gkhanna79 I've update the commit for the script.
For netci.groovy, I reverted minor changes, because we will update netci.groovy after discussing (1) which auto-PR test is going to be enabled and (2) command for triggering dotnet-bot.
For example, I think "Ubuntu14.04 arm Release Cross Build" is perferred over "Linux ARM Emulator SoftFP Release Cross Build", because we do not use emulator while building anymore for arm and armel. Later we can use emulator for test but it will be decided later. And this can be discussed with following up PR for netci.groovy.

gkhanna79
gkhanna79 reviewed Feb 15, 2017
View reviewed changes
Comment thread scripts/arm32_ci_script.sh
if [ "$__buildArch" == "arm" ]; then
__buildManagedCmd="./build-managed.sh -$__buildConfig -buildArch=$__buildArch -RuntimeOS=$__runtimeOS"
else
# TODO-armel: We can use same option to arm, i.e. -buildArch and -RuntimeOS options for armel,
Copy link
Copy Markdown
Member

@gkhanna79 gkhanna79 Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file an issue to track unifying this and add it to the main issue in Core-Setup where everything is being tracked.

Copy link
Copy Markdown
Member Author

@hqueue hqueue Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will :)

gkhanna79
gkhanna79 reviewed Feb 15, 2017
View reviewed changes
Comment thread scripts/arm32_ci_script.sh Outdated
#Mount the emulator
(set +x; echo 'Mounting emulator...')
mount_emulator
#(set +x; echo 'Mounting emulator...')
Copy link
Copy Markdown
Member

@gkhanna79 gkhanna79 Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete these?

Copy link
Copy Markdown
Member Author

@hqueue hqueue Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

gkhanna79
gkhanna79 reviewed Feb 15, 2017
View reviewed changes
Comment thread scripts/arm32_ci_script.sh Outdated
#Complete the cross build
(set +x; echo 'Building corefx...')
cross_build_corefx
#cross_build_corefx
Copy link
Copy Markdown
Member

@gkhanna79 gkhanna79 Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

gkhanna79
gkhanna79 reviewed Feb 15, 2017
View reviewed changes
Comment thread scripts/arm32_ci_script.sh
fi
;;
--arm)
__ARMRootfsImageBase="rootfs-u1404.ext4"
Copy link
Copy Markdown
Member

@gkhanna79 gkhanna79 Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this if we are using Docker image now?

Copy link
Copy Markdown
Member Author

@hqueue hqueue Feb 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkhanna79 Not necessary and it is not used for building corefx. I just leave this code to keep consistency in the script and this variable can be used when we enable testing using ARM emulator.

Copy link
Copy Markdown
Member

@gkhanna79 gkhanna79 Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning to use this script to mount the Arm emulator, given that the build is now being done in Docker image?

Copy link
Copy Markdown
Member Author

@hqueue hqueue Feb 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing is decided for testing yet and I just keep previous code. Do you have any idea for testing ? I think we also can make use of Docker for testing too and it may require further investigation. I think we can look into testing issue after building is done.

Copy link
Copy Markdown
Member

@gkhanna79 gkhanna79 Feb 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good - let me know your thoughts on testing once you have ideas on how you want to move ahead with it.

@hqueue
ARM CI script for arm and armel
ac43f0b 
Implement ARM CI script using Docker for arm and armel

Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
@hqueue
Copy link
Copy Markdown
Member Author

hqueue commented Feb 16, 2017

@dotnet-bot test ci please
@dotnet-bot test innerloop linuxarmemulator SoftFP Release
@dotnet-bot test innerloop linuxarmemulator HardFP Release

@gkhanna79 gkhanna79 merged commit 698c6b2 into dotnet:master Feb 16, 2017
@hqueue hqueue mentioned this pull request Feb 17, 2017
Merged
@karelz karelz modified the milestone: 2.0.0 Feb 22, 2017
This was referenced Jan 30, 2020
Closed
Closed
Closed
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@gkhanna79
Merge pull request dotnet/corefx#15900 from hqueue/arm/ci
a0445cf 
[ARM/CI] ARM CI script for arm and armel

Commit migrated from dotnet/corefx@698c6b2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gkhanna79 gkhanna79 gkhanna79 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mellinoe mellinoe

@hqueue hqueue

Labels

arch-arm32 area-Infrastructure-libraries * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) os-linux Linux OS (any supported distro)

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@hqueue @dotnet-bot @gkhanna79 @stephentoub @karelz @mellinoe @dnfclas