This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add test for GetCurrentMethod called inside inlineable method#16071
Merged
Conversation
Member
Author
|
This is targeted test for the bug fixed by dotnet/coreclr#9537 Note that this test is not running by default because of https://github.com/dotnet/corefx/issues/15849 |
gkhanna79
reviewed
Feb 11, 2017
| Assert.True(m.IsStatic); | ||
| Assert.True(m.IsPublic); | ||
| Assert.True(m.DeclaringType == typeof(MethodBaseTests)); | ||
| throw new Exception(); |
Member
There was a problem hiding this comment.
Why are we throwing an exception here?
Member
Author
There was a problem hiding this comment.
Left over from me verifying whether the test runs or not...
jkotas
force-pushed
the
inlineable-getcurrentmethod
branch
2 times, most recently
from
e691e5b to
837fca0
Compare
jkotas
force-pushed
the
inlineable-getcurrentmethod
branch
from
837fca0 to
a38b83b
Compare
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.