This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Change base class of OperationAbortedException to SystemException#16391
Merged
Conversation
Member
|
LGTM. (Separately, I don't see OperationAbortedException exposed in the ref for SqlClient, so it doesn't look like the type is directly nameable outside of this assembly.) |
Member
Is there a reason for why it's not exposed? It's public in full .net and xamarin. |
Member
|
Ah, I just found https://github.com/dotnet/corefx/issues/15143 :) |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Change base class of OperationAbortedException to SystemException Commit migrated from dotnet/corefx@f3a7a8b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12351 changed lots of Exceptions to be derived from SystemException instead of Exception but looks like System.Data.OperationAbortedException was forgotten.
From our referencesource dump - it uses SystemException: https://github.com/mono/mono/blob/master/mcs/class/referencesource/System.Data/System/Data/OperationAbortedException.cs#L19
PS:
Also, I am wondering why https://github.com/dotnet/corefx/blob/master/src/System.Data.SqlClient/src/System/Data/OperationAbortedException.cs#L18 is not replaced with https://github.com/dotnet/corefx/blob/master/src/System.Data.Common/src/System/HResults.cs#L26
(I see HResults is internal so SqlClient can not use it, but that magic number doesn't look good).