This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Cleanup File Lock/Unlock OSX tests.#16449
Merged
Merged
Conversation
stephentoub
reviewed
Feb 24, 2017
| using (FileStream fs = File.Open(path, FileMode.Open, FileAccess.ReadWrite, FileShare.ReadWrite)) | ||
| { | ||
| Assert.Throws<PlatformNotSupportedException>(() => fs.Lock(0, 100)); | ||
| Assert.Throws<PlatformNotSupportedException>(() => fs.Unlock(0, 100)); |
Member
There was a problem hiding this comment.
Might want to also verify that after these calls the FileShare'ing for the FileStream is still valid, i.e. that we didn't somehow mess up the lock that was already there.
stephentoub
approved these changes
Feb 24, 2017
Member
|
Blocked on #16454 being merged |
Member
|
@dotnet-bot test this please |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Cleanup File Lock/Unlock OSX tests. Commit migrated from dotnet/corefx@71b1d03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds/modifies tests for FileStream lock/unlock after dotnet/coreclr#9769.