This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Expose and test KeyValuePair.Create#16561
Merged
Merged
Conversation
stephentoub
reviewed
Mar 1, 2017
safern
reviewed
Mar 2, 2017
Member
There was a problem hiding this comment.
LGTM.
The reason why CI is failing is because the implementation is not in uapaot so you need to update the ApiCompatBaseline just by running locally:
msbuild src\System.Runtime\src\System.Runtime.csproj /p:TargetGroup=uapaot /p:BaselineAllApiCompatError=true
then just update the PR
Author
|
Thanks @safern. I get multiple updates in the ApiCompatBaseline.uapaot.txt file, but have only pushed the ones related to my change. Hopefully that'll work |
Member
|
@hughbe it worked. Thanks for doing this! |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Expose and test KeyValuePair.Create Commit migrated from dotnet/corefx@03a54d3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And add some unit tests for KVP construction and ToString
Fixes #2127