This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Support compiling for ARM Android#16819
Merged
Merged
Conversation
karelz
added
area-Infrastructure-libraries
arch-arm32
os-unsupported
Contributor
|
Looks good to me. @cydhaselton do you want to look over this as well? |
Contributor
|
@mellinoe: Looks fine. Something to think about is the duplication of the cross-toolchain between coreclr, corefx and (in future) core-setup. Shouldn't be an issue if cross-compiling and not building on device but in the future it may be good to look at a more space-efficient method. |
8 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Support compiling for ARM Android Commit migrated from dotnet/corefx@80a8fff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes are required to native source code as well, I'll try to submit separate PRs for that.