This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Coreclr update#17269
Merged
Merged
Conversation
…25118-01, beta-25117-00, beta-25117-02, respectively
Contributor
Author
|
@Maoni0 below test is failing in corefx |
Contributor
Author
|
System.Tests.GCTests.GetAllocatedBytesForCurrentThread(size: 100000) [FAIL] |
Member
|
This is known issue https://github.com/dotnet/corefx/issues/16606 cc @swgillespie This means that @Maoni0 's fix have not fully fixed the issue. |
Member
|
@dotnet-bot test Innerloop Windows_NT Debug x86 Build and Test please |
Member
|
I will take a look tomorrow |
Member
|
yeah the fixes I made wouldn't affect this test as it was allocating on LOH (the fixes I made only affected SOH allocs). I just created a PR to fix this issue. |
dotnet-bot
pushed a commit
that referenced
this pull request
Mar 28, 2018
* Adding Memory.Pin() to eventually replace Memory.Retain(bool) * Fix copy/paste error and return default for when object is null. * Fix XML comments. Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
ahsonkhan
pushed a commit
that referenced
this pull request
Mar 29, 2018
* Adding Memory.Pin() to eventually replace Memory.Retain(bool) (#17269) * Adding Memory.Pin() to eventually replace Memory.Retain(bool) * Fix copy/paste error and return default for when object is null. * Fix XML comments. Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> * Add Memory.Pin to the ref and add tests. * Add Pin tests * Update calls to Retain(true) to now call Pin() * Remove extra space in tests. * Add Pin to the ApiCompatBaseline for uapaot.
dotnet-bot
pushed a commit
that referenced
this pull request
Mar 30, 2018
* Adding Memory.Pin() to eventually replace Memory.Retain(bool) * Fix copy/paste error and return default for when object is null. * Fix XML comments. Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
that referenced
this pull request
Mar 30, 2018
* Adding Memory.Pin() to eventually replace Memory.Retain(bool) * Fix copy/paste error and return default for when object is null. * Fix XML comments. Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
that referenced
this pull request
Mar 30, 2018
* Adding Memory.Pin() to eventually replace Memory.Retain(bool) * Fix copy/paste error and return default for when object is null. * Fix XML comments. Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Adding Memory.Pin() to eventually replace Memory.Retain(bool) (dotnet/corefx#17269) * Adding Memory.Pin() to eventually replace Memory.Retain(bool) * Fix copy/paste error and return default for when object is null. * Fix XML comments. Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com> * Add Memory.Pin to the ref and add tests. * Add Pin tests * Update calls to Retain(true) to now call Pin() * Remove extra space in tests. * Add Pin to the ApiCompatBaseline for uapaot. Commit migrated from dotnet/corefx@bb5c468
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.