Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25321-03, preview1-25322-02, preview1-25321-02, beta-25322-00, beta-25322-00, beta-25322-00, preview1-25322-01, respectively (master) by dotnet-bot · Pull Request #20025 · dotnet/corefx

dotnet-bot · 2017-05-19T22:42:30Z

No description provided.

stephentoub · 2017-05-20T11:14:08Z

-    <CoreFxExpectedPrerelease>preview2-25319-04</CoreFxExpectedPrerelease>
-    <CoreClrExpectedPrerelease>preview2-25316-03</CoreClrExpectedPrerelease>
+    <CoreFxExpectedPrerelease>preview1-25320-01</CoreFxExpectedPrerelease>
+    <CoreClrExpectedPrerelease>preview1-25319-05</CoreClrExpectedPrerelease>


@dagood, why are these going backwards to preview1?

master is building for 2.1.0 now, so the prerelease spec is reset to preview1. It's clearer in the full package version upgrade: 2.0.0-preview2-25319-02 -> 2.1.0-preview1-25320-02.

Thanks, @dagood. Do you know why the build is failing? It seems to be missing something for corelib that was previously there.

The CoreCLR it's trying to insert is missing https://github.com/dotnet/coreclr/pull/11355/files

I don't know why this is happening, but I don't see any infrastructural reason for it. @weshaggard @gkhanna79

That PR was merged 19 days ago - a fundamental issue with the change should have come up earlier. Have we looked into where is the ApiCompat tool looking for the API? In SPC.dll or some library built in CoreFX?

See my fix with 444ea73. The issue was we were downgrading the package minor version so it was picking an older runtime package without these changes.

…TestILC, Standard to preview1-25321-03, preview1-25322-02, preview1-25321-02, beta-25322-00, beta-25322-00, beta-25322-00, preview1-25322-01, respectively

weshaggard · 2017-05-22T19:57:50Z

Pulling down to build and looking into this.

Instead of only looking at the prerelease we also now get the full package version during our update to avoid issues when major/minor/patch version change

weshaggard · 2017-05-22T21:30:09Z

@ericstj @dagood could you guys please take a look at 444ea73 which should fix corefx.

weshaggard · 2017-05-22T22:37:12Z

Getting a number of OverflowExcptions thrown only on the windows release build https://ci.dot.net/job/dotnet_corefx/job/master/job/windows_nt_release_prtest/8250/#showFailuresLink, going to kick the build again to see if there was some transient issue.

@dotnet-bot test Innerloop Windows_NT Release x64 Build and Test please

weshaggard · 2017-05-22T23:40:29Z

Same set of overflowexception test failures. @jkotas @stephentoub are you guys aware of any coreclr changes that might impact these?

dagood · 2017-05-22T23:52:51Z

    </PackageReference>
    <PackageReference Include="runtime.native.System.Data.SqlClient.sni">
-      <Version>4.4.0-$(CoreFxExpectedPrerelease)</Version>
+      <Version>$(PackageVersion)-$(CoreFxExpectedPrerelease)</Version>


You should be able to get this full version from the CoreFX build-info rather than assembling it here.

Yes I started to do that but then I noticed we have multiple sni versions we care about one is this one and one is the RID specific packages so instead of adding yet another SNIVersion into dependencies.props I went this route. However I don't really care for this approach much either so we should consider changing that later. For now this part of the PR is unblocked, just need to figure out the test failures now.

Agreed, unblocked. There's also an active question of whether this identity package should be created during the SNI build instead (https://github.com/dotnet/corefx/issues/16918), so wiring up another property for this might not be worthwhile.

dotnet-bot · 2017-05-23T01:06:56Z

Couldn't update this pull request: Head commit author 'Wes Haggard' is not 'dotnet-bot'
Would have applied 'Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25322-03, preview1-25322-02, preview1-25322-04, beta-25322-00, beta-25322-00, beta-25322-00, preview1-25322-01, respectively'

dotnet-bot · 2017-05-23T04:24:19Z

Couldn't update this pull request: Head commit author 'Wes Haggard' is not 'dotnet-bot'
Would have applied 'Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25322-03, preview1-25323-02, preview1-25322-04, beta-25322-00, beta-25322-00, beta-25322-00, preview1-25322-01, respectively'

jkotas · 2017-05-23T05:10:06Z

Same set of overflowexception test failures. @jkotas @stephentoub are you guys aware of any coreclr changes that might impact these?

It is likely a JIT codegen regression. Number of JIT changes went in last few days.

@dotnet/jit-contrib Could you please take a look?

dotnet-bot · 2017-05-23T13:26:44Z

Couldn't update this pull request: Head commit author 'Wes Haggard' is not 'dotnet-bot'
Would have applied 'Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25322-03, preview1-25323-02, preview1-25322-04, beta-25322-00, beta-25322-00, beta-25322-00, preview1-25323-01, respectively'

dotnet-bot · 2017-05-23T14:03:42Z

Couldn't update this pull request: Head commit author 'Wes Haggard' is not 'dotnet-bot'
Would have applied 'Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25323-01, preview1-25323-02, preview1-25322-04, beta-25322-00, beta-25322-00, beta-25322-00, preview1-25323-01, respectively'

pgavlin · 2017-05-23T16:11:31Z

@jkotas this does look like it could be a JIT issue: I can repro the failures in the Decimal tests by simply replacing the JIT in the current test layout with a JIT built at the current sources and setting ZapDisable to 1. Binary searching now.

pgavlin · 2017-05-23T16:29:31Z

I've narrowed this down to the changes that came in with dotnet/coreclr#10453. @JosephTremoulet, can you take a look?

briansull · 2017-05-23T17:28:18Z

I also filed a recent Silent Bad codegen issue Involving returning structs, could be the same bug Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Pat Gavlin <notifications@github.com> Sent: Tuesday, May 23, 2017 9:30:12 AM To: dotnet/corefx Cc: Brian Sullivan; Team mention Subject: Re: [dotnet/corefx] Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25321-03, preview1-25322-02, preview1-25321-02, beta-25322-00, beta-25322-00, beta-25322-00, preview1-25322-01, respectively (master)... I've narrowed this down to the changes that came in with dotnet/coreclr#10453<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fcoreclr%2Fpull%2F10453&data=02%7C01%7Cbriansul%40microsoft.com%7C84e6a4742fa34b2bfa5d08d4a1f8fdd3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636311538167070129&sdata=QcF0wLQY0BzeWLabLdt6P%2FDlhy6byuNuaTW2XB3i2M8%3D&reserved=0>. @JosephTremoulet<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjosephtremoulet&data=02%7C01%7Cbriansul%40microsoft.com%7C84e6a4742fa34b2bfa5d08d4a1f8fdd3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636311538167070129&sdata=Shr4HJaTXvwh2bOA7mOMRYB5BaS08sOX0GT90SqSOvs%3D&reserved=0>, can you take a look? — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fcorefx%2Fpull%2F20025%23issuecomment-303457728&data=02%7C01%7Cbriansul%40microsoft.com%7C84e6a4742fa34b2bfa5d08d4a1f8fdd3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636311538167070129&sdata=U5GDy1Zuva8hd2ovBLL2IdI07WgmJG1z2aYAaa2QOaM%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALFV_IwhH9cfLcYe9wnQTNTQKQJLsIxuks5r8wmUgaJpZM4NhFnQ&data=02%7C01%7Cbriansul%40microsoft.com%7C84e6a4742fa34b2bfa5d08d4a1f8fdd3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636311538167070129&sdata=WfdttAFgi9wTwF4XkNw9G0OuwnoLv8zcd%2FZlQXoztzs%3D&reserved=0>.

dotnet-bot · 2017-05-24T01:22:59Z

Couldn't update this pull request: Head commit author 'Wes Haggard' is not 'dotnet-bot'
Would have applied 'Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25323-02, preview1-25323-02, preview1-25323-04, beta-25322-00, beta-25322-00, beta-25322-00, preview1-25323-01, respectively'

dotnet-bot · 2017-05-24T01:58:44Z

Couldn't update this pull request: Head commit author 'Wes Haggard' is not 'dotnet-bot'
Would have applied 'Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25323-02, preview1-25324-01, preview1-25323-04, beta-25322-00, beta-25322-00, beta-25322-00, preview1-25323-01, respectively'

dotnet-bot · 2017-05-24T03:16:06Z

Couldn't update this pull request: Head commit author 'Wes Haggard' is not 'dotnet-bot'
Would have applied 'Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25323-02, preview1-25324-01, preview1-25323-04, beta-25322-00, beta-25324-00, beta-25324-00, preview1-25323-01, respectively'

stephentoub · 2017-05-24T13:18:26Z

@weshaggard, should we close this? With your commit, dotnet-bot can't update this, so we won't be able to get an updated CoreCLR with the fix when there is one.

dotnet-bot · 2017-05-24T13:23:50Z

Couldn't update this pull request: Head commit author 'Wes Haggard' is not 'dotnet-bot'
Would have applied 'Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25324-01, preview1-25324-02, preview1-25323-04, beta-25322-00, beta-25324-00, beta-25324-00, preview1-25323-01, respectively'

dotnet-bot · 2017-05-24T13:28:31Z

Couldn't update this pull request: Head commit author 'Wes Haggard' is not 'dotnet-bot'
Would have applied 'Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25324-01, preview1-25324-02, preview1-25323-04, beta-25322-00, beta-25324-00, beta-25324-00, preview1-25323-01, respectively'

dotnet-bot · 2017-05-24T13:48:14Z

Couldn't update this pull request: Head commit author 'Wes Haggard' is not 'dotnet-bot'
Would have applied 'Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25324-01, preview1-25324-02, preview1-25323-04, beta-25322-00, beta-25324-00, beta-25324-00, preview1-25324-01, respectively'

weshaggard · 2017-05-24T16:05:41Z

@weshaggard, should we close this? With your commit, dotnet-bot can't update this, so we won't be able to get an updated CoreCLR with the fix when there is one.

Fair point. I will push just my changes a change that undoes the CoreCLR update but keeps the rest of my changes which should make this PR green so we can merge and then the next update should be able to run smoothly.

weshaggard · 2017-05-24T16:08:29Z

Pushed an update, hopefully it should be green and when it is we should merge these changes and the let the next auto-update pick-up from their.

stephentoub · 2017-05-24T17:17:56Z

Thanks, @weshaggard. Sounds good.

danmoseley · 2017-05-24T17:30:03Z

System.Net.HttpListener tests appear to have hung again. Everything else completed. https://github.com/dotnet/corefx/issues/20246

dnfclas added the cla-already-signed label May 19, 2017

dotnet-bot changed the title ~~Update CoreClr, CoreSetup to preview1-25319-05, preview2-25319-05, respectively (master)~~ Update CoreClr, CoreFx, CoreSetup to preview1-25319-05, preview1-25320-01, preview2-25319-05, respectively (master) May 20, 2017

dotnet-bot force-pushed the master-UpdateDependencies branch from 4168372 to 6feda2e Compare May 20, 2017 01:18

stephentoub reviewed May 20, 2017

View reviewed changes

dotnet-bot changed the title ~~Update CoreClr, CoreFx, CoreSetup to preview1-25319-05, preview1-25320-01, preview2-25319-05, respectively (master)~~ Update CoreClr, CoreFx, CoreSetup to preview1-25319-05, preview1-25320-02, preview2-25319-05, respectively (master) May 20, 2017

dotnet-bot force-pushed the master-UpdateDependencies branch from 6feda2e to a7d1600 Compare May 20, 2017 13:56

karelz modified the milestone: 2.1.0 May 20, 2017

dotnet-bot changed the title ~~Update CoreClr, CoreFx, CoreSetup to preview1-25319-05, preview1-25320-02, preview2-25319-05, respectively (master)~~ Update CoreClr, CoreFx, CoreSetup to preview1-25320-05, preview1-25320-02, preview1-25320-01, respectively (master) May 20, 2017

dotnet-bot force-pushed the master-UpdateDependencies branch from a7d1600 to fe7a314 Compare May 20, 2017 18:52

dotnet-bot changed the title ~~Update CoreClr, CoreFx, CoreSetup to preview1-25320-05, preview1-25320-02, preview1-25320-01, respectively (master)~~ Update CoreClr, CoreFx, CoreSetup to preview1-25320-05, preview1-25321-01, preview1-25320-02, respectively (master) May 21, 2017

dotnet-bot force-pushed the master-UpdateDependencies branch from fe7a314 to edde868 Compare May 21, 2017 01:32

dotnet-bot force-pushed the master-UpdateDependencies branch from edde868 to f4ddf12 Compare May 21, 2017 05:17

dotnet-bot force-pushed the master-UpdateDependencies branch from f4ddf12 to f03674c Compare May 21, 2017 12:56

dotnet-bot force-pushed the master-UpdateDependencies branch from f03674c to 759856f Compare May 21, 2017 13:26

dotnet-bot force-pushed the master-UpdateDependencies branch from 759856f to 78fb7ac Compare May 22, 2017 01:00

dotnet-bot force-pushed the master-UpdateDependencies branch from 78fb7ac to 61698c2 Compare May 22, 2017 01:18

dotnet-bot force-pushed the master-UpdateDependencies branch from 61698c2 to e7c6b4a Compare May 22, 2017 03:16

dotnet-bot force-pushed the master-UpdateDependencies branch from e7c6b4a to 6e63b61 Compare May 22, 2017 05:16

dotnet-bot force-pushed the master-UpdateDependencies branch from 6e63b61 to ec4692e Compare May 22, 2017 13:25

Update CoreClr, CoreFx, CoreSetup, External, ProjectNTfs, ProjectNTfs…

544b07a

…TestILC, Standard to preview1-25321-03, preview1-25322-02, preview1-25321-02, beta-25322-00, beta-25322-00, beta-25322-00, preview1-25322-01, respectively

dotnet-bot force-pushed the master-UpdateDependencies branch from ec4692e to 544b07a Compare May 22, 2017 13:26

Update properties used for auto-package update

444ea73

Instead of only looking at the prerelease we also now get the full package version during our update to avoid issues when major/minor/patch version change

dagood reviewed May 22, 2017

View reviewed changes

Undo the update to CoreCLR version for now to unblock other updates

93016f1

JosephTremoulet mentioned this pull request May 24, 2017

Update full-struct references to promoted IBR args dotnet/coreclr#11883

Merged

weshaggard merged commit 271a2f6 into dotnet:master May 24, 2017

danmoseley mentioned this pull request May 25, 2017

Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25326-02, preview1-25324-02, preview1-25326-03, beta-25326-02, beta-25326-02, preview1-25326-01, respectively (master) #20290

Merged

JosephTremoulet mentioned this pull request Jan 31, 2020

JIT: add struct promotion stress mode dotnet/runtime#8227

Closed

Conversation

dotnet-bot commented May 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weshaggard commented May 22, 2017

Uh oh!

weshaggard commented May 22, 2017

Uh oh!

weshaggard commented May 22, 2017

Uh oh!

weshaggard commented May 22, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dotnet-bot commented May 23, 2017

Uh oh!

dotnet-bot commented May 23, 2017

Uh oh!

jkotas commented May 23, 2017

Uh oh!

dotnet-bot commented May 23, 2017

Uh oh!

dotnet-bot commented May 23, 2017

Uh oh!

pgavlin commented May 23, 2017

Uh oh!

pgavlin commented May 23, 2017

Uh oh!

briansull commented May 23, 2017 via email

Uh oh!

dotnet-bot commented May 24, 2017

Uh oh!

dotnet-bot commented May 24, 2017

Uh oh!

dotnet-bot commented May 24, 2017

Uh oh!

stephentoub commented May 24, 2017

Uh oh!

dotnet-bot commented May 24, 2017

Uh oh!

dotnet-bot commented May 24, 2017

Uh oh!

dotnet-bot commented May 24, 2017

Uh oh!

weshaggard commented May 24, 2017

Uh oh!

weshaggard commented May 24, 2017

Uh oh!

stephentoub commented May 24, 2017

Uh oh!

danmoseley commented May 24, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

dotnet-bot commented May 19, 2017 •

edited

Loading