This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove two checks for EXPRFLAG values in Microsoft.CSharp that are never set#22533
Merged
Conversation
We never have an implicit this within a dynamic expression (if an argument to an expression with implicit this has a dynamic argument, then the static binder has already selected the correct object or types argument), so don't check for it when checking static-ness is correct
Literal status is never set (and rather meaningless after static compilation), so remove branch depending on it. Entails removal of ERR_LiteralDoubleCast, contributes to #22470
JonHanna
force-pushed
the
ms_cs_never_set_exprflag
branch
from
250277d to
7a2aaf2
Compare
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Feb 12, 2019
* Renaming RuntimeEventSource to NativeRuntimeEventSource * missed a couple of comments and XPlatEventLogger * rename DotNETRuntimeEventSource.cs to NativeRuntimeEventSource.cs * use condition= instead of ifdef * removing ifdef from NativeRuntimeEventSource.cs * Fix case for 'eventing' directory in csproj * Fix unix builds * This should fix unix build... Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
stephentoub
pushed a commit
that referenced
this pull request
Feb 13, 2019
* Renaming RuntimeEventSource to NativeRuntimeEventSource * missed a couple of comments and XPlatEventLogger * rename DotNETRuntimeEventSource.cs to NativeRuntimeEventSource.cs * use condition= instead of ifdef * removing ifdef from NativeRuntimeEventSource.cs * Fix case for 'eventing' directory in csproj * Fix unix builds * This should fix unix build... Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…ver set (dotnet/corefx#22533) * Remove checks for implicit this. We never have an implicit this within a dynamic expression (if an argument to an expression with implicit this has a dynamic argument, then the static binder has already selected the correct object or types argument), so don't check for it when checking static-ness is correct * Remove check for literal constant. Literal status is never set (and rather meaningless after static compilation), so remove branch depending on it. Entails removal of ERR_LiteralDoubleCast, contributes to dotnet/corefx#22470 Commit migrated from dotnet/corefx@2511abe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We never have an implicit this within a dynamic expression (if an argument to an expression with implicit this has a dynamic argument, then the static binder has already selected the correct object or type argument), so don't check for it when checking static-ness (stasis? 😉) is correct
Literal status is never set (and rather meaningless after static compilation), so remove branch depending on it.
Entails removal of
ERR_LiteralDoubleCast, contributes to #22470